Introduce new claims constants classes

Author: kevinchalet

src/AspNet.Security.OAuth.Autodesk/AutodeskAuthenticationConstants.cs

@@ -7,31 +7,14 @@
 namespace AspNet.Security.OAuth.Autodesk
 {
     /// <summary>
-    /// Constants used by the Autodesk authentication middleware.
+    /// Contains constants specific to the <see cref="AutodeskAuthenticationHandler"/>.
     /// </summary>
     public static class AutodeskAuthenticationConstants
     {
         public static class Claims
         {
-            /// <summary>
-            /// Name of the claim containing a boolean value indicating
-            /// whether the user's email has been verified.
-            /// </summary>
             public const string EmailVerified = "urn:autodesk:emailverified";
-
-            /// <summary>
-            /// Name of the claim containing a boolean value indicating
-            /// whether the user has enabled two factor authentication.
-            /// </summary>
             public const string TwoFactorEnabled = "urn:autodesk:twofactorenabled";
         }
-
-        public static class Scopes
-        {
-            /// <summary>
-            /// Name of the OAuth2 scope used for reading Autodesk user profile.
-            /// </summary>
-            public const string UserProfileRead = "user-profile:read";
-        }
     }
 }

src/AspNet.Security.OAuth.Autodesk/AutodeskAuthenticationOptions.cs

@@ -26,7 +26,7 @@ public AutodeskAuthenticationOptions()
             TokenEndpoint = AutodeskAuthenticationDefaults.TokenEndpoint;
             UserInformationEndpoint = AutodeskAuthenticationDefaults.UserInformationEndpoint;
 
-            Scope.Add(AutodeskAuthenticationConstants.Scopes.UserProfileRead);
+            Scope.Add("user-profile:read");
         }
     }
 }

src/AspNet.Security.OAuth.Bitbucket/BitbucketAuthenticationConstants.cs

@@ -0,0 +1,20 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+namespace AspNet.Security.OAuth.Bitbucket
+{
+    /// <summary>
+    /// Contains constants specific to the <see cref="BitbucketAuthenticationHandler"/>.
+    /// </summary>
+    public static class BitbucketAuthenticationConstants
+    {
+        public static class Claims
+        {
+            public const string DisplayName = "urn:bitbucket:name";
+            public const string Website = "urn:bitbucket:url";
+        }
+    }
+}

src/AspNet.Security.OAuth.Bitbucket/BitbucketAuthenticationHandler.cs

@@ -15,6 +15,7 @@
 using Microsoft.AspNetCore.Http.Authentication;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json.Linq;
+using static AspNet.Security.OAuth.Bitbucket.BitbucketAuthenticationConstants;
 
 namespace AspNet.Security.OAuth.Bitbucket
 {
@@ -49,8 +50,8 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync([NotNull]
             identity.AddOptionalClaim(ClaimTypes.NameIdentifier, BitbucketAuthenticationHelper.GetIdentifier(payload), Options.ClaimsIssuer)
                     .AddOptionalClaim(ClaimTypes.Name, BitbucketAuthenticationHelper.GetLogin(payload), Options.ClaimsIssuer)
                     .AddOptionalClaim(ClaimTypes.Email, BitbucketAuthenticationHelper.GetEmail(payload), Options.ClaimsIssuer)
-                    .AddOptionalClaim("urn:bitbucket:name", BitbucketAuthenticationHelper.GetName(payload), Options.ClaimsIssuer)
-                    .AddOptionalClaim("urn:bitbucket:url", BitbucketAuthenticationHelper.GetLink(payload), Options.ClaimsIssuer);
+                    .AddOptionalClaim(Claims.DisplayName, BitbucketAuthenticationHelper.GetName(payload), Options.ClaimsIssuer)
+                    .AddOptionalClaim(Claims.Website, BitbucketAuthenticationHelper.GetLink(payload), Options.ClaimsIssuer);
 
             // When the email address is not public, retrieve it from
             // the emails endpoint if the user:email scope is specified.

src/AspNet.Security.OAuth.DeviantArt/DeviantArtAuthenticationConstants.cs

@@ -0,0 +1,19 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+namespace AspNet.Security.OAuth.DeviantArt
+{
+    /// <summary>
+    /// Contains constants specific to the <see cref="DeviantArtAuthenticationHandler"/>.
+    /// </summary>
+    public static class DeviantArtAuthenticationConstants
+    {
+        public static class Claims
+        {
+            public const string Username = "urn:deviantart:name";
+        }
+    }
+}

src/AspNet.Security.OAuth.DeviantArt/DeviantArtAuthenticationHandler.cs

@@ -15,6 +15,7 @@
 using Microsoft.AspNetCore.Http.Authentication;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json.Linq;
+using static AspNet.Security.OAuth.DeviantArt.DeviantArtAuthenticationConstants;
 
 namespace AspNet.Security.OAuth.DeviantArt
 {
@@ -48,7 +49,7 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync([NotNull]
 
             identity.AddOptionalClaim(ClaimTypes.NameIdentifier, DeviantArtAuthenticationHelper.GetIdentifier(payload), Options.ClaimsIssuer)
                     .AddOptionalClaim(ClaimTypes.Name, DeviantArtAuthenticationHelper.GetLogin(payload), Options.ClaimsIssuer)
-                    .AddOptionalClaim("urn:DeviantArt:name", DeviantArtAuthenticationHelper.GetName(payload), Options.ClaimsIssuer);
+                    .AddOptionalClaim(Claims.Username, DeviantArtAuthenticationHelper.GetName(payload), Options.ClaimsIssuer);
 
             var principal = new ClaimsPrincipal(identity);
             var ticket = new AuthenticationTicket(principal, properties, Options.AuthenticationScheme);

src/AspNet.Security.OAuth.EVEOnline/EVEOnlineAuthenticationConstants.cs

@@ -0,0 +1,19 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+namespace AspNet.Security.OAuth.EVEOnline
+{
+    /// <summary>
+    /// Contains constants specific to the <see cref="EVEOnlineAuthenticationHandler"/>.
+    /// </summary>
+    public static class EVEOnlineAuthenticationConstants
+    {
+        public static class Claims
+        {
+            public const string Scopes = "urn:eveonline:scopes";
+        }
+    }
+}

src/AspNet.Security.OAuth.Fitbit/FitbitAuthenticationConstants.cs

@@ -0,0 +1,20 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+namespace AspNet.Security.OAuth.Fitbit
+{
+    /// <summary>
+    /// Contains constants specific to the <see cref="FitbitAuthenticationHandler"/>.
+    /// </summary>
+    public static class FitbitAuthenticationConstants
+    {
+        public static class Claims
+        {
+            public const string Avatar = "urn:fitbit:avatar";
+            public const string Avatar150 = "urn:fitbit:avatar150";
+        }
+    }
+}

src/AspNet.Security.OAuth.Fitbit/FitbitAuthenticationHandler.cs

@@ -18,6 +18,7 @@
 using Microsoft.AspNetCore.Http.Authentication;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json.Linq;
+using static AspNet.Security.OAuth.Fitbit.FitbitAuthenticationConstants;
 
 namespace AspNet.Security.OAuth.Fitbit
 {
@@ -51,8 +52,8 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync([NotNull]
 
             identity.AddOptionalClaim(ClaimTypes.NameIdentifier, FitbitAuthenticationHelper.GetIdentifier(payload), Options.ClaimsIssuer)
                     .AddOptionalClaim(ClaimTypes.Name, FitbitAuthenticationHelper.GetLogin(payload), Options.ClaimsIssuer)
-                    .AddOptionalClaim("urn:fitbit:avatar", FitbitAuthenticationHelper.GetAvatar(payload), Options.ClaimsIssuer)
-                    .AddOptionalClaim("urn:fitbit:avatar150", FitbitAuthenticationHelper.GetAvatar150(payload), Options.ClaimsIssuer);
+                    .AddOptionalClaim(Claims.Avatar, FitbitAuthenticationHelper.GetAvatar(payload), Options.ClaimsIssuer)
+                    .AddOptionalClaim(Claims.Avatar150, FitbitAuthenticationHelper.GetAvatar150(payload), Options.ClaimsIssuer);
 
             var principal = new ClaimsPrincipal(identity);
             var ticket = new AuthenticationTicket(principal, properties, Options.AuthenticationScheme);

src/AspNet.Security.OAuth.GitHub/GitHubAuthenticationConstants.cs

@@ -0,0 +1,20 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (http://www.apache.org/licenses/LICENSE-2.0)
+ * See https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers
+ * for more information concerning the license and the contributors participating to this project.
+ */
+
+namespace AspNet.Security.OAuth.GitHub
+{
+    /// <summary>
+    /// Contains constants specific to the <see cref="GitHubAuthenticationHandler"/>.
+    /// </summary>
+    public static class GitHubAuthenticationConstants
+    {
+        public static class Claims
+        {
+            public const string Name = "urn:github:name";
+            public const string Url = "urn:github:url";
+        }
+    }
+}