update according to the feedback (#5)

Jinhuafei · HongGit · commit 3bdaea8f0abb · 2018-04-04T13:22:04.000-07:00
* update according to the feedback

* update lisence and fix some test issues

* update license msg in cs file

* clean up
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -0,0 +1,50 @@
+# How to contribute
+
+One of the easiest ways to contribute is to participate in discussions and discuss issues. You can also contribute by submitting pull requests with code changes.
+
+
+## General feedback and discussions?
+Please start a discussion on the [Issue tracker](https://github.com/aspnet/AspNetSessionState/issues).
+
+
+## Bugs and feature requests?
+For non-security related bugs please log a new issue according to the [Functional bug template](https://github.com/aspnet/AspNetSessionState/wiki/Functional-bug-template).
+
+
+
+## Reporting security issues and bugs
+Security issues and bugs should be reported privately, via email, to the Microsoft Security Response Center (MSRC)  secure@microsoft.com. You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Further information, including the MSRC PGP key, can be found in the [Security TechCenter](https://technet.microsoft.com/en-us/security/ff852094.aspx).
+
+
+## Contributing code and content
+
+**Obtaining the source code**
+
+If you are an outside contributer, please fork the repository. See the GitHub documentation for [forking a repo](https://help.github.com/articles/fork-a-repo/) if you have any questions about this. 
+
+**Submitting a pull request**
+
+You will need to sign a [Contributor License Agreement](https://cla.dotnetfoundation.org/) when submitting your pull request. To complete the Contributor License Agreement (CLA), you will need to follow the instructions provided by the CLA bot when you send the pull request. This needs to only be done once for any .NET Foundation OSS project.
+
+If you don't know what a pull request is read this article: https://help.github.com/articles/using-pull-requests. Make sure the respository can build and all tests pass. 
+
+**Commit/Pull Request Format**
+
+```
+Summary of the changes (Less than 80 chars)
+ - Detail 1
+ - Detail 2
+
+Addresses #bugnumber (in this specific format)
+```
+
+**Tests**
+
+-  Tests need to be provided for every bug/feature that is completed.
+-  Tests only need to be present for issues that need to be verified by QA (e.g. not tasks)
+-  If there is a scenario that is far too hard to test there does not need to be a test for it.
+  - "Too hard" is determined by the team as a whole.
+
+**Feedback**
+
+Your pull request will now go through extensive checks by the subject matter experts on our team. Please be patient; we have hundreds of pull requests across all of our repositories. Update your pull request according to feedback until it is approved by one of the ASP.NET team members. After that, one of our team members will add the pull request to **dev**.
diff --git a/License.txt b/License.txt
@@ -1,15 +1,21 @@
-Copyright (c) Microsoft Open Technologies, Inc.  All rights reserved.
-Microsoft Open Technologies would like to thank its contributors, a list of whom
-are at http://aspnetwebstack.codeplex.com/wikipage?title=Contributors.
+Copyright (c) Microsoft Corporation
+All rights reserved.
 
-Licensed under the Apache License, Version 2.0 (the "License"); you
-may not use this file except in compliance with the License. You may
-obtain a copy of the License at
+MIT License
 
-http://www.apache.org/licenses/LICENSE-2.0
+Permission is hereby granted, free of charge, to any person obtaining a copy of
+this software and associated documentation files (the ""Software""), to deal in
+the Software without restriction, including without limitation the rights to
+use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
+the Software, and to permit persons to whom the Software is furnished to do so,
+subject to the following conditions:
 
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-implied. See the License for the specific language governing permissions
-and limitations under the License.
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
+IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
+CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
diff --git a/Readme.md b/Readme.md
@@ -6,6 +6,9 @@ SessionStateModule is ASP.NET’s default session-state handler which retrieves
 2. Run build.cmd. This will build Nuget package and run all the unit tests.
 3. All the build artifacts will be under aspnetsessionstate\bin\Release\ folder.
 
+## How to contribute
+Information on contributing to this repo is in the [Contributing Guide](CONTRIBUTING.md).
+
 ## Settings of the module and providers
 
 + #### Microsoft.AspNet.SessionState.SessionStateModule
diff --git a/build.cmd b/build.cmd
@@ -7,7 +7,6 @@ set logOptions=/flp:Summary;Verbosity=m;LogFile=msbuild.log /flp1:warningsonly;l
 echo Please build from VS 2015(or newer version) Developer Command Prompt
 
 :BUILD
-REM %MSBUILDEXE% "%~dp0\MicrosoftAspNetSessionState.msbuild" %logOptions% /v:d /maxcpucount /nodeReuse:false %*
 msbuild "%~dp0\MicrosoftAspNetSessionState.msbuild" %logOptions% /v:m /maxcpucount /nodeReuse:false %*
 
 endlocal
diff --git a/src/CosmosDBSessionStateProviderAsync/CosmosDBSessionStateProviderAsync.cs b/src/CosmosDBSessionStateProviderAsync/CosmosDBSessionStateProviderAsync.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/CosmosDBSessionStateProviderAsync/Properties/AssemblyInfo.cs b/src/CosmosDBSessionStateProviderAsync/Properties/AssemblyInfo.cs
@@ -1,4 +1,7 @@
-﻿using System.Reflection;
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
+
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
diff --git a/src/CosmosDBSessionStateProviderAsync/SessionStateActionsConverter.cs b/src/CosmosDBSessionStateProviderAsync/SessionStateActionsConverter.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState {
     using Microsoft.AspNet.SessionState.Resources;
diff --git a/src/CosmosDBSessionStateProviderAsync/SessionStateItem.cs b/src/CosmosDBSessionStateProviderAsync/SessionStateItem.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/CosmosDBSessionStateProviderAsync/TimeSpanConverter.cs b/src/CosmosDBSessionStateProviderAsync/TimeSpanConverter.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/AppSettings.cs b/src/SessionStateModule/AppSettings.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/InProcSessionStateStoreAsync.cs b/src/SessionStateModule/InProcSessionStateStoreAsync.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/Properties/AssemblyInfo.cs b/src/SessionStateModule/Properties/AssemblyInfo.cs
@@ -1,4 +1,7 @@
-﻿using System.Reflection;
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
+
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
diff --git a/src/SessionStateModule/SessionEventSource.cs b/src/SessionStateModule/SessionEventSource.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/SessionOnEndTarget.cs b/src/SessionStateModule/SessionOnEndTarget.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/SessionStateModuleAsync.cs b/src/SessionStateModule/SessionStateModuleAsync.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/SessionStateStoreProviderAsyncBase.cs b/src/SessionStateModule/SessionStateStoreProviderAsyncBase.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SessionStateModule/TaskAsyncHelper.cs b/src/SessionStateModule/TaskAsyncHelper.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/ISqlSessionStateRepository.cs b/src/SqlSessionStateProviderAsync/ISqlSessionStateRepository.cs
@@ -1,13 +1,13 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
     using System;
     using System.Threading.Tasks;
     using System.Web.SessionState;
 
-    internal interface ISqlSessionStateRepository
+    interface ISqlSessionStateRepository
     {
         void CreateSessionStateTable();
 
diff --git a/src/SqlSessionStateProviderAsync/Properties/AssemblyInfo.cs b/src/SqlSessionStateProviderAsync/Properties/AssemblyInfo.cs
@@ -1,4 +1,7 @@
-﻿using System.Reflection;
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
+
+using System.Reflection;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
diff --git a/src/SqlSessionStateProviderAsync/SqlCommandExtension.cs b/src/SqlSessionStateProviderAsync/SqlCommandExtension.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlCommandHelper.cs b/src/SqlSessionStateProviderAsync/SqlCommandHelper.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlInMemoryTableSessionStateRepository.cs b/src/SqlSessionStateProviderAsync/SqlInMemoryTableSessionStateRepository.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlParameterCollectionExtension.cs b/src/SqlSessionStateProviderAsync/SqlParameterCollectionExtension.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlSessionStateProviderAsync.cs b/src/SqlSessionStateProviderAsync/SqlSessionStateProviderAsync.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlSessionStateRepository.cs b/src/SqlSessionStateProviderAsync/SqlSessionStateRepository.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/src/SqlSessionStateProviderAsync/SqlSessionStateRepositoryUtil.cs b/src/SqlSessionStateProviderAsync/SqlSessionStateRepositoryUtil.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState
 {
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/CosmosDBSessionStateProviderAsyncTest.cs b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/CosmosDBSessionStateProviderAsyncTest.cs
@@ -1,5 +1,5 @@
-﻿// Copyright (c) .NET Foundation. All rights reserved.
-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT license. See the License.txt file in the project root for full license information.
 
 namespace Microsoft.AspNet.SessionState.CosmosDBSessionStateAsyncProvider.Test
 {
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test.csproj b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test.csproj
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/Properties/AssemblyInfo.cs b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/Properties/AssemblyInfo.cs
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/SessionStateItemTest.cs b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/SessionStateItemTest.cs
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/app.config b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/app.config
diff --git a/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/packages.config b/test/Microsoft.AspNet.SessionState.CosmosDBSessionStateProviderAsync.Test/packages.config
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test.csproj b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test.csproj
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/Properties/AssemblyInfo.cs b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/Properties/AssemblyInfo.cs
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/SqlCommandHelperTest.cs b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/SqlCommandHelperTest.cs
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/SqlSessionStateAsyncProviderTest.cs b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/SqlSessionStateAsyncProviderTest.cs
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/app.config b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/app.config
diff --git a/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/packages.config b/test/Microsoft.AspNet.SessionState.SqlSessionStateProviderAsync.Test/packages.config

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`		`-// Copyright (c) .NET Foundation. All rights reserved.`
`2`		`-// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.`
	`1`	`+// Copyright (c) Microsoft Corporation. All rights reserved.`
	`2`	`+// Licensed under the MIT license. See the License.txt file in the project root for full license information.`
`3`	`3`
`4`	`4`	`namespace Microsoft.AspNet.SessionState`
`5`	`5`	`{`