Spacebar on the "Files" node should toggle state

phil-allen-msft · phil-allen-msft · commit 534a843b86cc · 2024-04-24T10:40:00.000-07:00
If the "Files" node is partially checked, the user using spacebar will find nothing happens on spacebar because packageItem.IsChecked is null, so !packageItem.IsChecked is also null. Adjust spacebar behavior to match mouseclick behavior
diff --git a/src/LibraryManager.Vsix/UI/Controls/PackageContentsTreeView.xaml.cs b/src/LibraryManager.Vsix/UI/Controls/PackageContentsTreeView.xaml.cs
@@ -31,7 +31,15 @@ private void OnPreviewKeyUp(object sender, KeyEventArgs e)
 
                 if (packageItem != null)
                 {
-                    packageItem.IsChecked = !packageItem.IsChecked;
+                    if (packageItem.IsChecked.HasValue)
+                    {
+                        packageItem.IsChecked = !packageItem.IsChecked;
+                    }
+                    else
+                    {
+                        // if it is partially checked, clear all selections, just like clicking with the mouse
+                        packageItem.IsChecked = false;
+                    }
                     e.Handled = true;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,15 @@ private void OnPreviewKeyUp(object sender, KeyEventArgs e)`
`31`	`31`
`32`	`32`	`if (packageItem != null)`
`33`	`33`	`{`
`34`		`- packageItem.IsChecked = !packageItem.IsChecked;`
	`34`	`+ if (packageItem.IsChecked.HasValue)`
	`35`	`+ {`
	`36`	`+ packageItem.IsChecked = !packageItem.IsChecked;`
	`37`	`+ }`
	`38`	`+ else`
	`39`	`+ {`
	`40`	`+ // if it is partially checked, clear all selections, just like clicking with the mouse`
	`41`	`+ packageItem.IsChecked = false;`
	`42`	`+ }`
`35`	`43`	`e.Handled = true;`
`36`	`44`	`}`
`37`	`45`	`}`