When Activity stack is too deep, do not write Id to error message (#43)

When Activity step is too deep, do not write Id to error message

Author: Liudmila Molkova

src/Microsoft.AspNet.TelemetryCorrelation/ActivityHelper.cs

@@ -90,7 +90,11 @@ public static bool StopAspNetActivity(Activity activity, IDictionary contextItem
                     // in case it would ever be possible to have cycles in the Activity stack.
                     if (iteration++ == MaxActivityStackSize)
                     {
-                        AspNetTelemetryCorrelationEventSource.Log.ActivityStackIsTooDeep(currentActivity.Id, currentActivity.OperationName);
+                        // this is for internal error reporting
+                        AspNetTelemetryCorrelationEventSource.Log.ActivityStackIsTooDeepError();
+
+                        // this is for debugging
+                        AspNetTelemetryCorrelationEventSource.Log.ActivityStackIsTooDeepDetails(currentActivity.Id, currentActivity.OperationName);
                         activity.Stop();
                         return false;
                     }

src/Microsoft.AspNet.TelemetryCorrelation/AspNetTelemetryCorrelationEventSource.cs

@@ -53,10 +53,10 @@ public void FinishedActivityIsDetected(string id, string name)
             WriteEvent(6, id, name);
         }
 
-        [Event(7, Message = "Activity stack is too deep, Current Id: '{0}', Name: '{1}'", Level = EventLevel.Error)]
-        public void ActivityStackIsTooDeep(string id, string name)
+        [Event(7, Message = "System.Diagnostics.Activity stack is too deep. This is a code authoring error, Activity will not be stopped.", Level = EventLevel.Error)]
+        public void ActivityStackIsTooDeepError()
         {
-            WriteEvent(7, id, name);
+            WriteEvent(7);
         }
 
         [Event(8, Message = "Activity restored, Id='{0}'", Level = EventLevel.Informational)]
@@ -70,6 +70,12 @@ public void OnExecuteRequestStepInvokationError(string error)
         {
             WriteEvent(9, error);
         }
+
+        [Event(10, Message = "System.Diagnostics.Activity stack is too deep. Current Id: '{0}', Name: '{1}'", Level = EventLevel.Warning)]
+        public void ActivityStackIsTooDeepDetails(string id, string name)
+        {
+            WriteEvent(10, id, name);
+        }
     }
 }
 #pragma warning restore SA1600 // Elements must be documented