Skip to content

Commit 52ba93a

Browse files
authored
default_http_client is not using specified proxy (#78)
1 parent 7e78fd1 commit 52ba93a

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

src/signalrclient/connection_impl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace signalr
3939
else
4040
{
4141
#ifdef USE_CPPRESTSDK
42-
m_http_client_factory = [](const signalr_client_config&) { return std::unique_ptr<class http_client>(new default_http_client()); };
42+
m_http_client_factory = [](const signalr_client_config& signalr_client_config) { return std::unique_ptr<class http_client>(new default_http_client(signalr_client_config)); };
4343
#endif
4444
}
4545

src/signalrclient/default_http_client.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414

1515
namespace signalr
1616
{
17+
default_http_client::default_http_client(const signalr_client_config& config) noexcept
18+
: m_config(config)
19+
{ }
20+
1721
void default_http_client::send(const std::string& url, http_request& request,
1822
std::function<void(const http_response&, std::exception_ptr)> callback, cancellation_token token)
1923
{
@@ -82,7 +86,7 @@ namespace signalr
8286
cts.cancel();
8387
});
8488

85-
web::http::client::http_client client(utility::conversions::to_string_t(url));
89+
web::http::client::http_client client(utility::conversions::to_string_t(url), m_config.get_http_client_config());
8690
client.request(http_request, cts.get_token())
8791
.then([context, callback](pplx::task<web::http::http_response> response_task)
8892
{

src/signalrclient/default_http_client.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,20 @@
44

55
#pragma once
66

7+
#include "signalrclient/signalr_client_config.h"
78
#include "signalrclient/http_client.h"
89

910
namespace signalr
1011
{
1112
class default_http_client : public http_client
1213
{
1314
public:
15+
explicit default_http_client(const signalr_client_config& config = {}) noexcept;
16+
1417
void send(const std::string& url, http_request& request,
1518
std::function<void(const http_response&, std::exception_ptr)> callback, cancellation_token token) override;
19+
20+
private:
21+
signalr_client_config m_config;
1622
};
1723
}

0 commit comments

Comments
 (0)