Skip to content

Commit 67b0133

Browse files
committed
refactored
1 parent d16657c commit 67b0133

File tree

2 files changed

+11
-14
lines changed
  • SimpleTaskSystemSPA_AngularJs_EntityFramework/SimpleTaskSystem.Web

2 files changed

+11
-14
lines changed

SimpleTaskSystemSPA_AngularJs_EntityFramework/SimpleTaskSystem.Web/Abp/Framework/scripts/libs/angular/abp.ng.js

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,17 @@
44
return;
55
}
66

7-
// 'abp' module ///////////////////////////////////////////////////////////
8-
97
var abpModule = angular.module('abp', []);
108

119
abpModule.config([
1210
'$httpProvider', function ($httpProvider) {
1311
$httpProvider.interceptors.push(function ($q) {
12+
13+
var defaultError = {
14+
message: 'Ajax request is not succeed!',
15+
details: 'Error detail is not sent by server.'
16+
};
17+
1418
return {
1519
'response': function (response) {
1620
if (!response.config || !response.config.abp || !response.data) {
@@ -19,21 +23,14 @@
1923

2024
var defer = $q.defer();
2125

22-
if (response.data.targetUrl) { //TODO: Check if it works and does not prevent return value!
23-
location.href = data.targetUrl;
24-
}
25-
2626
if (response.data.success === true) {
2727
response.data = response.data.result;
2828
defer.resolve(response);
2929
} else { //data.success === false
3030
if (response.data.error) {
3131
abp.message.error(response.data.error.message);
3232
} else {
33-
response.data.error = {
34-
message: 'Ajax request is not succeed!',
35-
details: 'Error detail is not sent by server.'
36-
};
33+
response.data.error = defaultError;
3734
}
3835

3936
abp.log.error(response.data.error.message + ' | ' + response.data.error.details);
@@ -46,6 +43,10 @@
4643
}
4744
}
4845

46+
if (response.data.targetUrl) {
47+
location.href = data.targetUrl;
48+
}
49+
4950
return defer.promise;
5051
}
5152
};

SimpleTaskSystemSPA_AngularJs_EntityFramework/SimpleTaskSystem.Web/App/Main/views/task/list.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,7 @@
1919
taskService.getTasks({
2020
state: $scope.selectedTaskState > 0 ? $scope.selectedTaskState : null
2121
}).success(function (data) {
22-
console.log(arguments);
2322
vm.tasks = data.tasks;
24-
}).error(function (a) {
25-
console.log('error!');
26-
console.log(arguments);
2723
});
2824
};
2925

0 commit comments

Comments
 (0)