resolved #83

Author: ismcagdas

aspnet-core/src/AbpCompanyName.AbpProjectName.Application/MultiTenancy/TenantAppService.cs

@@ -17,6 +17,7 @@
 
 namespace AbpCompanyName.AbpProjectName.MultiTenancy
 {
+    [AbpAuthorize(PermissionNames.Pages_Tenants)]
     public class TenantAppService : AsyncCrudAppService<Tenant, TenantDto, int, PagedResultRequestDto, CreateTenantDto, TenantDto>, ITenantAppService
     {
         private readonly TenantManager _tenantManager;
@@ -44,14 +45,6 @@ IPasswordHasher<User> passwordHasher
             _abpZeroDbMigrator = abpZeroDbMigrator;
             _passwordHasher = passwordHasher;
             _userManager = userManager;
-
-            //todo@ismail: move to AbpAuthorize attribute when this is resolved https://github.com/aspnetboilerplate/aspnetboilerplate/issues/2253
-            CreatePermissionName
-                = GetAllPermissionName
-                    = GetPermissionName
-                        = UpdatePermissionName
-                            = DeletePermissionName
-                                = PermissionNames.Pages_Tenants;
         }
 
         public override async Task<TenantDto> Create(CreateTenantDto input)
@@ -118,7 +111,7 @@ public override async Task Delete(EntityDto<int> input)
             await _tenantManager.DeleteAsync(tenant);
         }
 
-        protected virtual void CheckErrors(IdentityResult identityResult)
+        private void CheckErrors(IdentityResult identityResult)
         {
             identityResult.CheckErrors(LocalizationManager);
         }

aspnet-core/src/AbpCompanyName.AbpProjectName.Application/Roles/RoleAppService.cs

@@ -16,6 +16,7 @@
 
 namespace AbpCompanyName.AbpProjectName.Roles
 {
+    [AbpAuthorize(PermissionNames.Pages_Roles)]
     public class RoleAppService : AsyncCrudAppService<Role, RoleDto, int, PagedResultRequestDto, CreateRoleDto, RoleDto>, IRoleAppService
     {
         private readonly RoleManager _roleManager;
@@ -24,13 +25,6 @@ public class RoleAppService : AsyncCrudAppService<Role, RoleDto, int, PagedResul
         public RoleAppService(IRepository<Role> repository, RoleManager roleManager, UserManager userManager)
             : base(repository)
         {
-            //todo@ismail: move to AbpAuthorize attribute when this is resolved https://github.com/aspnetboilerplate/aspnetboilerplate/issues/2253
-            CreatePermissionName
-                = GetAllPermissionName
-                    = GetPermissionName
-                        = UpdatePermissionName
-                            = DeletePermissionName = PermissionNames.Pages_Roles;
-
             _roleManager = roleManager;
             _userManager = userManager;
         }

aspnet-core/src/AbpCompanyName.AbpProjectName.Application/Users/UserAppService.cs

@@ -8,13 +8,15 @@
 using AbpCompanyName.AbpProjectName.Users.Dto;
 using Microsoft.AspNetCore.Identity;
 using System.Linq;
+using Abp.Authorization;
 using Microsoft.EntityFrameworkCore;
 using Abp.IdentityFramework;
 using AbpCompanyName.AbpProjectName.Authorization.Roles;
 using AbpCompanyName.AbpProjectName.Roles.Dto;
 
 namespace AbpCompanyName.AbpProjectName.Users
 {
+    [AbpAuthorize(PermissionNames.Pages_Users)]
     public class UserAppService : AsyncCrudAppService<User, UserDto, long, PagedResultRequestDto, CreateUserDto, UserDto>, IUserAppService
     {
         private readonly UserManager _userManager;
@@ -24,13 +26,6 @@ public class UserAppService : AsyncCrudAppService<User, UserDto, long, PagedResu
         public UserAppService(IRepository<User, long> repository, UserManager userManager, IPasswordHasher<User> passwordHasher, IRepository<Role> roleRepository)
             : base(repository)
         {
-            //todo@ismail: move to AbpAuthorize attribute when this is resolved https://github.com/aspnetboilerplate/aspnetboilerplate/issues/2253
-            CreatePermissionName
-                = GetAllPermissionName
-                    = GetPermissionName
-                        = UpdatePermissionName
-                            = DeletePermissionName = PermissionNames.Pages_Users;
-
             _userManager = userManager;
             _passwordHasher = passwordHasher;
             _roleRepository = roleRepository;