core review fix(linting, typo fixes, l10n, etc)

iyilm4z · iyilm4z · commit ebd72274612e · 2020-04-29T01:10:24.000+03:00
diff --git a/angular/src/account/layout/account-footer.component.ts b/angular/src/account/layout/account-footer.component.ts
@@ -20,4 +20,4 @@ export class AccountFooterComponent extends AppComponentBase {
       this.appSession.application.releaseDate.format('YYYYDDMM') +
       ']';
   }
-}
+}
diff --git a/angular/src/app/layout/sidebar-menu.component.ts b/angular/src/app/layout/sidebar-menu.component.ts
@@ -92,19 +92,14 @@ export class SidebarMenuComponent extends AppComponentBase implements OnInit {
             'https://aspnetzero.com?ref=abptmpl',
             'far fa-circle'
           ),
-          new MenuItem(
-            'Description',
-            'https://aspnetzero.com/?ref=abptmpl#description',
-            'far fa-circle'
-          ),
           new MenuItem(
             'Features',
-            'https://aspnetzero.com/?ref=abptmpl#features',
+            'https://aspnetzero.com/Features?ref=abptmpl',
             'far fa-circle'
           ),
           new MenuItem(
             'Pricing',
-            'https://aspnetzero.com/?ref=abptmpl#pricing',
+            'https://aspnetzero.com/Pricing?ref=abptmpl#pricing',
             'far fa-circle'
           ),
           new MenuItem(
diff --git a/angular/src/app/layout/sidebar.component.ts b/angular/src/app/layout/sidebar.component.ts
@@ -1,12 +1,18 @@
-import { Component, ChangeDetectionStrategy, Renderer2 } from '@angular/core';
+import {
+  Component,
+  ChangeDetectionStrategy,
+  Renderer2,
+  OnInit
+} from '@angular/core';
 import { LayoutStoreService } from '@shared/layout/layout-store.service';
 
 @Component({
+  // tslint:disable-next-line:component-selector
   selector: 'sidebar',
   templateUrl: './sidebar.component.html',
   changeDetection: ChangeDetectionStrategy.OnPush
 })
-export class SidebarComponent {
+export class SidebarComponent implements OnInit {
   sidebarExpanded: boolean;
 
   constructor(
diff --git a/angular/src/app/users/change-password/change-password.component.html b/angular/src/app/users/change-password/change-password.component.html
@@ -25,7 +25,7 @@ <h1>{{ "UpdatePassword" | localize }}</h1>
                 </label>
                 <div class="col-md-9">
                   <input
-                    type="text"
+                    type="password"
                     class="form-control"
                     name="currentPassword"
                     id="currentPassword"
@@ -48,7 +48,7 @@ <h1>{{ "UpdatePassword" | localize }}</h1>
                 </label>
                 <div class="col-md-9">
                   <input
-                    type="text"
+                    type="password"
                     class="form-control"
                     name="newPassword"
                     id="newPassword"
@@ -75,7 +75,7 @@ <h1>{{ "UpdatePassword" | localize }}</h1>
                 </label>
                 <div class="col-md-9">
                   <input
-                    type="text"
+                    type="password"
                     class="form-control"
                     name="confirmNewPassword"
                     id="confirmNewPassword"
diff --git a/angular/src/app/users/reset-password/reset-password.component.html b/angular/src/app/users/reset-password/reset-password.component.html
@@ -12,7 +12,7 @@
     <div class="row">
       <div class="col-md-9 offset-md-3">
         <p class="text-info mb-1">
-          1. Enter your administrator password
+          {{ "ResetPasswordStepOneInfo" | localize }}
         </p>
       </div>
     </div>
@@ -40,7 +40,7 @@
     <div class="row">
       <div class="col-md-9 offset-md-3">
         <p class="text-info mb-1">
-          2. Copy this random password so you can send it to the user
+          {{ "ResetPasswordStepTwoInfo" | localize }}
         </p>
       </div>
     </div>
diff --git a/angular/src/app/users/users.component.html b/angular/src/app/users/users.component.html
@@ -169,45 +169,30 @@ <h1>{{ "Users" | localize }}</h1>
                   </div>
                 </td>
                 <td>
-                  <div class="btn-group" dropdown container="body">
-                    <button
-                      type="button"
-                      class="btn btn-default"
-                      (click)="editUser(user)"
-                    >
-                      <i class="fas fa-pencil-alt"></i>
-                      {{ "Edit" | localize }}
-                    </button>
-                    <button
-                      type="button"
-                      class="btn btn-default"
-                      dropdownToggle
-                    >
-                      <i class="fas fa-ellipsis-h"></i>
-                    </button>
-                    <ul *dropdownMenu class="dropdown-menu">
-                      <li role="menuitem">
-                        <a
-                          class="dropdown-item"
-                          href="javascript:;"
-                          (click)="delete(user)"
-                        >
-                          <i class="fas fa-trash"></i>
-                          {{ "Delete" | localize }}
-                        </a>
-                      </li>
-                      <li role="menuitem">
-                        <a
-                          class="dropdown-item"
-                          href="javascript:;"
-                          (click)="resetPassword(user)"
-                        >
-                          <i class="fas fa-lock"></i>
-                          {{ "ResetPassword" | localize }}
-                        </a>
-                      </li>
-                    </ul>
-                  </div>
+                  <button
+                    type="button"
+                    class="btn btn-sm bg-secondary"
+                    (click)="editUser(user)"
+                  >
+                    <i class="fas fa-pencil-alt"></i>
+                    {{ "Edit" | localize }}
+                  </button>
+                  <button
+                    type="button"
+                    class="btn btn-sm bg-danger mx-2"
+                    (click)="delete(user)"
+                  >
+                    <i class="fas fa-trash"></i>
+                    {{ "Delete" | localize }}
+                  </button>
+                  <button
+                    type="button"
+                    class="btn btn-sm bg-secondary"
+                    (click)="resetPassword(user)"
+                  >
+                    <i class="fas fa-lock"></i>
+                    {{ "ResetPassword" | localize }}
+                  </button>
                 </td>
               </tr>
             </tbody>
diff --git a/angular/src/app/users/users.component.ts b/angular/src/app/users/users.component.ts
@@ -50,6 +50,12 @@ export class UsersComponent extends PagedListingComponentBase<UserDto> {
     this.showResetPasswordUserDialog(user.id);
   }
 
+  clearFilters(): void {
+    this.keyword = '';
+    this.isActive = undefined;
+    this.getDataPage(1);
+  }
+
   protected list(
     request: PagedUsersRequestDto,
     pageNumber: number,
@@ -125,10 +131,4 @@ export class UsersComponent extends PagedListingComponentBase<UserDto> {
       this.refresh();
     });
   }
-
-  clearFilters(): void {
-    this.keyword = '';
-    this.isActive = undefined;
-    this.getDataPage(1);
-  }
 }
diff --git a/angular/src/shared/auth/app-auth.service.ts b/angular/src/shared/auth/app-auth.service.ts
@@ -3,12 +3,16 @@ import { AppConsts } from '@shared/AppConsts';
 
 @Injectable()
 export class AppAuthService {
-
-    logout(reload?: boolean): void {
-        abp.auth.clearToken();
-		abp.utils.setCookieValue(AppConsts.authorization.encryptedAuthTokenName, undefined, undefined, abp.appPath);
-        if (reload !== false) {
-            location.href = AppConsts.appBaseUrl;
-        }
+  logout(reload?: boolean): void {
+    abp.auth.clearToken();
+    abp.utils.setCookieValue(
+      AppConsts.authorization.encryptedAuthTokenName,
+      undefined,
+      undefined,
+      abp.appPath
+    );
+    if (reload !== false) {
+      location.href = AppConsts.appBaseUrl;
     }
+  }
 }
diff --git a/angular/src/shared/components/validation/abp-validation.summary.component.ts b/angular/src/shared/components/validation/abp-validation.summary.component.ts
@@ -14,13 +14,13 @@ import { AbpValidationError } from './abp-validation.api';
   selector: 'abp-validation-summary',
   templateUrl: './abp-validation.summary.component.html'
 })
-export class ApbValidationSummaryComponent extends AppComponentBase
+export class AbpValidationSummaryComponent extends AppComponentBase
   implements OnInit {
   @Input() control: AbstractControl;
   @Input() controlEl: ElementRef;
   @Input() set customValidationErrors(val: AbpValidationError[]) {
     if (val && val.length > 0) {
-      let defaults = this.defaultValidationErrors.filter(
+      const defaults = this.defaultValidationErrors.filter(
         (defaultValidationError) =>
           !val.find(
             (customValidationError) =>
@@ -81,7 +81,7 @@ export class ApbValidationSummaryComponent extends AppComponentBase
       this._renderer.addClass(this.controlEl, 'is-invalid');
     }
 
-    let propertyValue = this.control.errors[error.name][error.propertyKey];
+    const propertyValue = this.control.errors[error.name][error.propertyKey];
     return !!propertyValue
       ? this.l(error.localizationKey, propertyValue)
       : this.l(error.localizationKey);
diff --git a/angular/src/shared/layout/layout-store.service.ts b/angular/src/shared/layout/layout-store.service.ts
@@ -5,11 +5,11 @@ import { LayoutConfig } from './layout-config';
 
 @Injectable()
 export class LayoutStoreService {
-  private configSource: BehaviorSubject<LayoutConfig>;
   public readonly config$: Observable<LayoutConfig>;
   private readonly initialLayoutConfig: LayoutConfig = {
     sidebarExpanded: false
   };
+  private configSource: BehaviorSubject<LayoutConfig>;
 
   constructor() {
     this.configSource = new BehaviorSubject(this.initialLayoutConfig);
diff --git a/angular/src/shared/shared.module.ts b/angular/src/shared/shared.module.ts
@@ -11,7 +11,7 @@ import { AppRouteGuard } from './auth/auth-route-guard';
 import { LocalizePipe } from '@shared/pipes/localize.pipe';
 
 import { AbpPaginationControlsComponent } from './components/pagination/abp-pagination-controls.component';
-import { ApbValidationSummaryComponent } from './components/validation/abp-validation.summary.component';
+import { AbpValidationSummaryComponent } from './components/validation/abp-validation.summary.component';
 import { AbpModalHeaderComponent } from './components/modal/abp-modal-header.component';
 import { AbpModalFooterComponent } from './components/modal/abp-modal-footer.component';
 import { LayoutStoreService } from './layout/layout-store.service';
@@ -29,7 +29,7 @@ import { EqualValidator } from './directives/equal-validator.directive';
     ],
     declarations: [
         AbpPaginationControlsComponent,
-        ApbValidationSummaryComponent,
+        AbpValidationSummaryComponent,
         AbpModalHeaderComponent,
         AbpModalFooterComponent,
         LocalizePipe,
@@ -39,7 +39,7 @@ import { EqualValidator } from './directives/equal-validator.directive';
     ],
     exports: [
         AbpPaginationControlsComponent,
-        ApbValidationSummaryComponent,
+        AbpValidationSummaryComponent,
         AbpModalHeaderComponent,
         AbpModalFooterComponent,
         LocalizePipe,
diff --git a/aspnet-core/src/AbpCompanyName.AbpProjectName.Core/Localization/SourceFiles/AbpProjectName.xml b/aspnet-core/src/AbpCompanyName.AbpProjectName.Core/Localization/SourceFiles/AbpProjectName.xml
@@ -114,5 +114,7 @@
     <text name="TotalRecordsCount">Total: {0}</text>
     <text name="Search">Search</text>
     <text name="Clear">Clear</text>
+    <text name="ResetPasswordStepOneInfo">1. Enter your administrator password</text>
+    <text name="ResetPasswordStepTwoInfo">2. Copy this random password so you can send it to the user</text>
   </texts>
 </localizationDictionary>

Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,4 @@ export class AccountFooterComponent extends AppComponentBase {`
`20`	`20`	`this.appSession.application.releaseDate.format('YYYYDDMM') +`
`21`	`21`	`']';`
`22`	`22`	`}`
`23`		`-}`
	`23`	`+}`