ci(py312): make MLX deps macOS/arm64-only; fix E402/import order; minor lint & requirements tidy

Author: asq-sheriff

app/database/scylla_connection.py

@@ -77,7 +77,7 @@ def reset_singleton(cls):
 
             import gc
             for _ in range(3):
-                collected = gc.collect()
+                gc.collect()
                 time.sleep(0.1)
 
             logger.info("ScyllaDB singleton reset complete")

app/services/chatbot_service.py

@@ -142,7 +142,7 @@ def __init__(
             GENERATION_SERVICE_AVAILABLE
         )
 
-        logger.info(f"Enhanced ChatbotService initialized")
+        logger.info("Enhanced ChatbotService initialized")
         logger.info(f"  Real generation available: {self.real_generation_available}")
         logger.info(f"  Response strategy: {self.cfg.response_strategy}")
         logger.info(f"  Context optimization: {self.cfg.context_window_optimization}")
@@ -622,16 +622,16 @@ def _generate_template_response(self, message: str, context: str) -> str:
             context_preview = context[:800] + "..." if len(context) > 800 else context
 
             return (
-                f"Based on the available information:\n\n"
+                "Based on the available information:\n\n"
                 f"{context_preview}\n\n"
                 f"This should help address your question about: \"{message[:100]}...\"\n\n"
-                f"If you need more specific details, please let me know!"
+                "If you need more specific details, please let me know!"
             )
         else:
             return (
                 f"I understand you're asking about: \"{message[:100]}...\"\n\n"
-                f"I don't have specific information available right now, but I'd be happy to help "
-                f"if you could provide more details or rephrase your question."
+                "I don't have specific information available right now, but I'd be happy to help "
+                "if you could provide more details or rephrase your question."
             )
 
     def _enhanced_fallback_answer(self, message: str, context: str = "") -> str:

app/services/embedding_service.py

@@ -84,7 +84,7 @@ def __init__(self, config: Optional[EmbeddingConfig] = None):
         # Memory monitoring
         self._process = psutil.Process()
 
-        logger.info(f"sentence-transformers/all-mpnet-base-v2 EmbeddingService initialized")
+        logger.info("sentence-transformers/all-mpnet-base-v2 EmbeddingService initialized")
 
     async def embed_query(self, text: str) -> List[float]:
         """

app/services/knowledge_service.py

@@ -243,7 +243,7 @@ def __init__(
 
         # FIXED: Check vector search availability at runtime, not init time
         # We'll check this when we actually need it
-        logger.info(f"  Atlas Vector Search available: Will check at runtime")
+        logger.info("  Atlas Vector Search available: Will check at runtime")
 
     def _get_mongo_manager(self):
         """Get the MongoDB manager instance - FIXED to use the getter function"""
@@ -845,7 +845,7 @@ async def mongo_hybrid_search_embeddings(
                     })
 
             if not candidates:
-                logger.warning(f"No documents found even with broader retrieval")
+                logger.warning("No documents found even with broader retrieval")
                 return []
 
             logger.info(f"Using {len(candidates)} candidates for re-ranking")

app/utils/seed_data.py

@@ -19,8 +19,6 @@
 
 from bson import ObjectId
 from motor.motor_asyncio import AsyncIOMotorCollection
-
-# Enhanced imports with better error handling
 from app.database.mongo_connection import enhanced_mongo_manager as mongo_manager
 from app.database.mongo_connection import init_enhanced_mongo, close_enhanced_mongo
 
@@ -741,7 +739,7 @@ async def _process_chunk_batch(self, chunk_data_batch: List[Dict], embedding_tex
 
             # Retry with smaller batch if enabled
             if len(chunk_data_batch) > 1 and self.config.max_retries > 0:
-                logger.warning(f"🔄 Retrying batch with smaller size...")
+                logger.warning("🔄 Retrying batch with smaller size...")
                 mid = len(chunk_data_batch) // 2
 
                 batch1 = await self._process_chunk_batch(chunk_data_batch[:mid], embedding_texts[:mid], emb_coll)

requirements.txt

@@ -53,7 +53,7 @@ mammoth==1.10.0
 MarkupSafe==3.0.2
 mlx==0.28.0; platform_system == "Darwin" and platform_machine == "arm64"
 mlx-lm==0.26.3; platform_system == "Darwin" and platform_machine == "arm64"
-mlx-metal==0.28.0; platform_system == "Darwin" and platform_machine == "arm64"
+mlx-metal>=0.28.0; platform_system == "Darwin" and platform_machine == "arm64"
 motor==3.7.1
 mpmath==1.3.0
 msgpack==1.1.1