Throw exception on failed request, extracted fetching headers to separate method to make overrideable (#82)

Co-authored-by: Josip Milotić <[email protected]>

Author: josip-milotic

src/App/Http/Controllers/RemoteCustomFieldController.php

@@ -126,7 +126,7 @@ public function resolveByIdentifierValue(RemoteType $remoteType, string $identif
 
         $data = collect($data)->where($remoteType->identifier_property, $identifierValue)->first();
 
-        $transformed = $this->mapSingle($remoteType->mappings, $data);
+        $transformed = is_array($data) ? $this->mapSingle($remoteType->mappings, $data) : $data;
 
         return response()->json($transformed);
     }

src/App/Models/RemoteType.php

@@ -52,12 +52,17 @@ public function getRemoteData()
             return Cache::get($cacheKey);
         }
 
-        $response = Http::withHeaders($this->headers ?: [])
+        $response = Http::withHeaders($this->getHeaders() ?: [])
             ->withBody($this->body, 'application/json')
-            ->{$this->method}($this->url)->json();
+            ->{$this->method}($this->url)->throw()->json();
 
         Cache::put($cacheKey, $response, config('asseco-custom-fields.remote_cache_ttl'));
 
         return $response;
     }
+
+    protected function getHeaders()
+    {
+        return $this->headers;
+    }
 }