cache (#108)

ngaspari · StyleCIBot · web-flow · commit 90fa613885ff · 2025-09-12T14:30:56.000+02:00
* cache

Don't use cache when $identifierValue is provided. Remote data source has pagination and does not return all the data at once

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot &lt;bot@styleci.io&gt;
diff --git a/src/App/Models/RemoteType.php b/src/App/Models/RemoteType.php
@@ -81,7 +81,7 @@ private function fetchData(?string $value = null, bool $search = false)
     public function getRemoteData(?string $identifierValue = null)
     {
         $cacheKey = 'remote_custom_field_' . $this->id;
-        if (config('asseco-custom-fields.should_cache_remote') && Cache::has($cacheKey)) {
+        if ((bool) $identifierValue && config('asseco-custom-fields.should_cache_remote') && Cache::has($cacheKey)) {
             return Cache::get($cacheKey);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ private function fetchData(?string $value = null, bool $search = false)`
`81`	`81`	`public function getRemoteData(?string $identifierValue = null)`
`82`	`82`	`{`
`83`	`83`	`$cacheKey = 'remote_custom_field_' . $this->id;`
`84`		`- if (config('asseco-custom-fields.should_cache_remote') && Cache::has($cacheKey)) {`
	`84`	`+ if ((bool) $identifierValue && config('asseco-custom-fields.should_cache_remote') && Cache::has($cacheKey)) {`
`85`	`85`	`return Cache::get($cacheKey);`
`86`	`86`	`}`
`87`	`87`