Fix major Sonar issues

Author: VanRoy

src/main/java/org/assertj/db/output/impl/PlainOutput.java

@@ -390,6 +390,10 @@ private static List<Integer> getColumnSizesList(Row... rows) {
       }
     }
 
+    if (row0 == null) {
+      return columnSizesList;
+    }
+
     List<String> columnsNameList = row0.getColumnsNameList();
     int index = 0;
     for (String columnName : columnsNameList) {

src/main/java/org/assertj/db/type/Table.java

@@ -184,6 +184,14 @@ public OrderType getType() {
       return type;
     }
 
+    @Override
+    public int hashCode() {
+      int hash = 7;
+      hash = 31 * hash + (type == null ? 0 : type.hashCode());
+      hash = 31 * hash + (name == null ? 0 : name.hashCode());
+      return hash;
+    }
+
     @Override
     public boolean equals(Object obj) {
       if (obj instanceof Order) {

src/test/java/org/assertj/db/type/Change_Exception_Test.java

@@ -15,48 +15,44 @@
 import org.assertj.db.common.AbstractTest;
 import org.junit.Test;
 
-import java.util.Arrays;
-
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.junit.Assert.fail;
+import static java.util.Collections.singletonList;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 /**
  * Tests on the exceptions of Change
- * 
+ *
  * @author Régis Pouiller
- * 
+ *
  */
 public class Change_Exception_Test extends AbstractTest {
 
   /**
    * This method should fail because the data type must be not null.
    */
   @Test
-  public void should_fail_because_datatype_must_be_not_null() {
-    try {
-      getChange(null, "name", ChangeType.CREATION, getRow(Arrays.asList(""), Arrays.asList(""), Arrays.asList(getValue(
-              null, null))),
-          getRow(Arrays.asList(""), Arrays.asList(""), Arrays.asList(getValue(null, null))));
-
-      fail("An exception must be raised");
-    } catch (Exception exception) {
-      assertThat(exception.getCause().getLocalizedMessage()).isEqualTo("The type of the data must be not null");
-    }
+  public void should_fail_because_datatype_must_be_not_null() throws Exception {
+
+    Row start = getRow(singletonList(""), singletonList(""), singletonList(getValue(null, null)));
+    Row end = getRow(singletonList(""), singletonList(""), singletonList(getValue(null, null)));
+
+    assertThatThrownBy(() -> getChange(null, "name", ChangeType.CREATION, start, end))
+        .isInstanceOf(Exception.class)
+        .getCause()
+        .hasMessage("The type of the data must be not null");
   }
 
   /**
    * This method should fail because the data name must be not null.
    */
   @Test
-  public void should_fail_because_dataname_must_be_not_null() {
-    try {
-      getChange(DataType.TABLE, null, ChangeType.CREATION, getRow(Arrays.asList(""), Arrays.asList(""), Arrays.asList(getValue(
-              null, null))),
-          getRow(Arrays.asList(""), Arrays.asList(""), Arrays.asList(getValue(null, null))));
-
-      fail("An exception must be raised");
-    } catch (Exception exception) {
-      assertThat(exception.getCause().getLocalizedMessage()).isEqualTo("The name of the data must be not null");
-    }
+  public void should_fail_because_dataname_must_be_not_null() throws Exception {
+
+    Row start = getRow(singletonList(""), singletonList(""), singletonList(getValue(null, null)));
+    Row end = getRow(singletonList(""), singletonList(""), singletonList(getValue(null, null)));
+
+    assertThatThrownBy(() -> getChange(DataType.TABLE, null, ChangeType.CREATION, start, end))
+        .isInstanceOf(Exception.class)
+        .getCause()
+        .hasMessage("The name of the data must be not null");
   }
 }

src/test/java/org/assertj/db/type/DateValue_Test.java

@@ -575,7 +575,7 @@ public void test_move_datetime() {
     assertThat(DateValue.of(2007, 12, 23).move(DateTimeValue.of(DateValue.of(0, -1, 0), TimeValue.of(0, 0)))).as("substract 1 month")
                         .isEqualTo(DateTimeValue.of(DateValue.of(2007, 11, 23)));
     assertThat(DateValue.of(2007, 12, 23).move(DateTimeValue.of(DateValue.of(0, -2, 0), TimeValue.of(0, 0)))).as("substract 2 months")
-                        .isEqualTo(DateValue.of(2007, 10, 23));
+                        .isEqualTo(DateTimeValue.of(DateValue.of(2007, 10, 23)));
 
     assertThat(DateValue.of(2007, 12, 23).move(DateTimeValue.of(DateValue.of(1, 0, 0), TimeValue.of(0, 0)))).as("add 1 year")
                         .isEqualTo(DateTimeValue.of(DateValue.of(2008, 12, 23)));