refactor: code cleanup

Author: digitalsadhu

.eslintrc

@@ -1,15 +1,14 @@
 {
   "root": true,
-  "extends": [
-    "finn",
-    "finn/node",
-    "finn-prettier"
-  ],
+  "extends": ["finn", "finn/node", "finn-prettier"],
   "parserOptions": {
-    "ecmaVersion": 2017
+    "ecmaVersion": 2017,
+    "ecmaFeatures": {
+      "experimentalObjectRestSpread": true
+    }
   },
   "env": {
     "node": true,
     "jest": true
   }
-}
+}

lib/reader.js

@@ -12,17 +12,16 @@ module.exports = async function reader(feeds = []) {
         `Expected every feed to be an array. Instead got "${feeds.join(', ')}"`
     );
 
-    feeds = feeds.reduce((prev, current) => prev.concat(current), []);
+    feeds = [].concat(...feeds);
 
-    const map = new Map();
+    const feedMap = new Map();
     feeds.forEach(feed => {
-        // because map preserves order, when we get a duplicate we actually
-        // need to append to the end of the map. We do that by deleting
-        // first and then adding to the map
-        map.delete(feed.id);
-        map.set(feed.id, feed);
+        // because feedMap preserves order, when we get a duplicate we actually
+        // need to append to the end of the feedMap. We do that by deleting
+        // first and then adding to the feedMap
+        feedMap.delete(feed.id);
+        feedMap.set(feed.id, feed);
     });
-    return Array.from(map.values())
-        .map(feed => feed.content.trim())
-        .join('\n\n');
+    const dedupedFeeds = Array.from(feedMap.values());
+    return dedupedFeeds.map(feed => feed.content.trim()).join('\n\n');
 };