Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Commit c502ddc

Browse files
committed
style(lib): Fix lint issues after project metafile and tooling update
1 parent 1fc9540 commit c502ddc

File tree

3 files changed

+39
-21
lines changed

3 files changed

+39
-21
lines changed

lib/reader.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const { dedupe, sort, setOrder } = require('./util');
77
const assert = require('assert');
88

99
module.exports = class Reader extends Readable {
10-
constructor (streams) {
10+
constructor(streams) {
1111
super();
1212

1313
assert(
@@ -25,7 +25,10 @@ module.exports = class Reader extends Readable {
2525
'Expected any/all arguments given to Reader constructor to be subclasses of Stream.'
2626
);
2727

28-
assert(streams.length, 'Expected at least one stream to be provided to new Reader(). Got none.');
28+
assert(
29+
streams.length,
30+
'Expected at least one stream to be provided to new Reader(). Got none.'
31+
);
2932

3033
const merged = mergeStream();
3134

@@ -73,7 +76,7 @@ module.exports = class Reader extends Readable {
7376
});
7477
}
7578

76-
_read () {
79+
_read() {
7780
return this.data.resume();
7881
}
7982
};

lib/util.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,31 +2,31 @@
22

33
const { Transform } = require('readable-stream');
44

5-
function compareByOrder (a, b) {
5+
function compareByOrder(a, b) {
66
if (a.order === b.order) {
77
return 0;
88
}
99
return a.order > b.order ? 1 : -1;
1010
}
1111

1212
class Dedupe extends Transform {
13-
constructor () {
13+
constructor() {
1414
super({
1515
objectMode: true,
1616
});
1717

1818
this.rows = new Map();
1919
}
2020

21-
_transform (chunk, enc, callback) {
21+
_transform(chunk, enc, callback) {
2222
if (chunk && chunk.id) {
2323
this.rows.set(chunk.id, chunk);
2424
}
2525

2626
callback();
2727
}
2828

29-
_flush (callback) {
29+
_flush(callback) {
3030
Array.from(this.rows.values())
3131
.sort(compareByOrder)
3232
.forEach(row => this.push(row));
@@ -35,37 +35,37 @@ class Dedupe extends Transform {
3535
}
3636

3737
class SetOrder extends Transform {
38-
constructor (index) {
38+
constructor(index) {
3939
super({
4040
objectMode: true,
4141
});
4242

4343
this.index = index;
4444
}
4545

46-
_transform (chunk, enc, callback) {
46+
_transform(chunk, enc, callback) {
4747
chunk.order = this.index;
4848
callback(null, chunk);
4949
}
5050
}
5151

5252
class Sort extends Transform {
53-
constructor () {
53+
constructor() {
5454
super({
5555
objectMode: true,
5656
});
5757

5858
this.rows = new Map();
5959
}
6060

61-
_transform (chunk, enc, callback) {
61+
_transform(chunk, enc, callback) {
6262
if (chunk && chunk.order != null) {
6363
this.rows.set(chunk.order, chunk);
6464
}
6565
callback();
6666
}
6767

68-
_flush (callback) {
68+
_flush(callback) {
6969
Array.from(this.rows.values())
7070
.sort(compareByOrder)
7171
.forEach(row => this.push(row));
@@ -74,13 +74,13 @@ class Sort extends Transform {
7474
}
7575

7676
module.exports = {
77-
dedupe () {
77+
dedupe() {
7878
return new Dedupe();
7979
},
80-
setOrder (index) {
80+
setOrder(index) {
8181
return new SetOrder(index);
8282
},
83-
sort () {
83+
sort() {
8484
return new Sort();
8585
},
8686
compareByOrder,

test/reader.test.js

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const path = require('path');
88
const { sort, dedupe, compareByOrder } = require('../lib/util');
99
const { Readable, PassThrough } = require('readable-stream');
1010

11-
function createSlowStream (sink, filePath, timeout = 1000) {
11+
function createSlowStream(sink, filePath, timeout = 1000) {
1212
const myStream = new PassThrough();
1313

1414
process.nextTick(() => myStream.emit('file found', filePath));
@@ -202,7 +202,7 @@ test('SortAndDedupe() rows without id value dropped', done => {
202202
const values = [{ id: 'asd' }, { x: '' }, { id: 'sdf' }];
203203
const stream = new Readable({
204204
objectMode: true,
205-
read () {
205+
read() {
206206
if (values.length === 0) {
207207
this.push(null);
208208
return;
@@ -231,7 +231,12 @@ test('new Reader([s1,s2,s3,s4]) ensure dedupe and correct css concat order', don
231231
const feedStream3 = sink.reader('c.json');
232232
const feedStream4 = sink.reader('d.json');
233233

234-
const reader = new Reader([feedStream1, feedStream2, feedStream3, feedStream4]);
234+
const reader = new Reader([
235+
feedStream1,
236+
feedStream2,
237+
feedStream3,
238+
feedStream4,
239+
]);
235240

236241
reader.on('pipeline ready', () => {
237242
const bundle = [];
@@ -258,7 +263,12 @@ test('new Reader([s1,s2,s3,s4]) operates correctly under slow speed conditions',
258263
const feedStream3 = createSlowStream(sink, 'c.json', 500);
259264
const feedStream4 = createSlowStream(sink, 'd.json', 100);
260265

261-
const reader = new Reader([feedStream1, feedStream2, feedStream3, feedStream4]);
266+
const reader = new Reader([
267+
feedStream1,
268+
feedStream2,
269+
feedStream3,
270+
feedStream4,
271+
]);
262272

263273
reader.on('pipeline ready', () => {
264274
const bundle = [];
@@ -281,10 +291,15 @@ test('compareByOrder(a, b) a and b are the same', () => {
281291

282292
test('sort() transform operating on stream items without order property', done => {
283293
expect.assertions(1);
284-
const items = [{ order: 1 }, { order: null }, { order: undefined }, { noOrder: 'hi' }];
294+
const items = [
295+
{ order: 1 },
296+
{ order: null },
297+
{ order: undefined },
298+
{ noOrder: 'hi' },
299+
];
285300
const stream = new Readable({
286301
objectMode: true,
287-
read () {
302+
read() {
288303
if (!items.length) {
289304
this.push(null);
290305
return;

0 commit comments

Comments
 (0)