Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Commit a523182

Browse files
committed
fix: change css endpoint to output css
add transform stream and convert object mode to strings
1 parent 8e58a81 commit a523182

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

lib/middleware.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ const express = require('express');
77
const JsWriter = require('asset-pipe-js-writer');
88
const CssWriter = require('asset-pipe-css-writer');
99
const emits = require('emits');
10+
const { Transform } = require('stream');
1011

1112
module.exports = class Middleware extends EventEmitter {
1213
constructor(jsFiles = [], cssFiles = [], options = {}) {
@@ -43,7 +44,7 @@ module.exports = class Middleware extends EventEmitter {
4344
});
4445

4546
this.writers.css.on('update', () => {
46-
const bundler = this.writers.css.bundle();
47+
const bundler = this.writers.css;
4748

4849
bundler.on('error', e => {
4950
this.emit('error', e);
@@ -96,7 +97,7 @@ module.exports = class Middleware extends EventEmitter {
9697

9798
js() {
9899
return (req, res, next) => {
99-
res.writeHead(200, { 'Content-Type': 'application/javascript' });
100+
res.type('javascript');
100101
const bundler = this.writers.js.bundle();
101102

102103
bundler.on('error', cleanup);
@@ -115,8 +116,15 @@ module.exports = class Middleware extends EventEmitter {
115116

116117
css() {
117118
return (req, res, next) => {
118-
res.writeHead(200, { 'Content-Type': 'text/css' });
119-
const bundler = this.writers.css.bundle();
119+
res.type('css');
120+
const bundler = this.writers.css.pipe(
121+
new Transform({
122+
objectMode: true,
123+
transform(chunk, enc, cb) {
124+
cb(null, chunk.content);
125+
},
126+
})
127+
);
120128

121129
bundler.on('error', cleanup);
122130

0 commit comments

Comments
 (0)