test: add additional tests to stop the code coverage badgering

Author: digitalsadhu

lib/reader.js

@@ -14,6 +14,8 @@ const Boom = require('boom');
 const assert = require('assert');
 const envify = require('envify');
 
+const DEFAULT_ENV = 'development';
+
 /**
  * Unpacks given feeds into directory structure before
  * bundling everything together with browserify.
@@ -46,7 +48,7 @@ module.exports = async (feeds, options) => {
     const opts = {
         sourceMaps: false,
         minify: false,
-        env: process.env.NODE_ENV || 'development',
+        env: process.env.NODE_ENV || DEFAULT_ENV,
         ...options,
     };
 

test/__snapshots__/reader.test.js.snap

@@ -61720,6 +61720,144 @@ exports[`should handle node_modules dependencies 1`] = `
 "
 `;
 
+exports[`should replace NODE_ENV with default of "development" 1`] = `
+"(function e(t, n, r) {
+  function s(o, u) {
+    if (!n[o]) {
+      if (!t[o]) {
+        var a = typeof require == \\"function\\" && require;
+        if (!u && a) return a(o, !0);
+        if (i) return i(o, !0);
+        var f = new Error(\\"Cannot find module '\\" + o + \\"'\\");
+        throw ((f.code = \\"MODULE_NOT_FOUND\\"), f);
+      }
+      var l = (n[o] = { exports: {} });
+      t[o][0].call(
+        l.exports,
+        function(e) {
+          var n = t[o][1][e];
+          return s(n ? n : e);
+        },
+        l,
+        l.exports,
+        e,
+        t,
+        n,
+        r
+      );
+    }
+    return n[o].exports;
+  }
+  var i = typeof require == \\"function\\" && require;
+  for (var o = 0; o < r.length; o++) s(r[o]);
+  return s;
+})(
+  {
+    1: [
+      function(require, module, exports) {
+        console.log(\\"test\\");
+      },
+      {}
+    ]
+  },
+  {},
+  [1]
+);
+"
+`;
+
+exports[`should replace NODE_ENV with given value 1`] = `
+"(function e(t, n, r) {
+  function s(o, u) {
+    if (!n[o]) {
+      if (!t[o]) {
+        var a = typeof require == \\"function\\" && require;
+        if (!u && a) return a(o, !0);
+        if (i) return i(o, !0);
+        var f = new Error(\\"Cannot find module '\\" + o + \\"'\\");
+        throw ((f.code = \\"MODULE_NOT_FOUND\\"), f);
+      }
+      var l = (n[o] = { exports: {} });
+      t[o][0].call(
+        l.exports,
+        function(e) {
+          var n = t[o][1][e];
+          return s(n ? n : e);
+        },
+        l,
+        l.exports,
+        e,
+        t,
+        n,
+        r
+      );
+    }
+    return n[o].exports;
+  }
+  var i = typeof require == \\"function\\" && require;
+  for (var o = 0; o < r.length; o++) s(r[o]);
+  return s;
+})(
+  {
+    1: [
+      function(require, module, exports) {
+        console.log(\\"production\\");
+      },
+      {}
+    ]
+  },
+  {},
+  [1]
+);
+"
+`;
+
+exports[`should replace NODE_ENV with process.env.NODE_ENV 1`] = `
+"(function e(t, n, r) {
+  function s(o, u) {
+    if (!n[o]) {
+      if (!t[o]) {
+        var a = typeof require == \\"function\\" && require;
+        if (!u && a) return a(o, !0);
+        if (i) return i(o, !0);
+        var f = new Error(\\"Cannot find module '\\" + o + \\"'\\");
+        throw ((f.code = \\"MODULE_NOT_FOUND\\"), f);
+      }
+      var l = (n[o] = { exports: {} });
+      t[o][0].call(
+        l.exports,
+        function(e) {
+          var n = t[o][1][e];
+          return s(n ? n : e);
+        },
+        l,
+        l.exports,
+        e,
+        t,
+        n,
+        r
+      );
+    }
+    return n[o].exports;
+  }
+  var i = typeof require == \\"function\\" && require;
+  for (var o = 0; o < r.length; o++) s(r[o]);
+  return s;
+})(
+  {
+    1: [
+      function(require, module, exports) {
+        console.log(\\"production\\");
+      },
+      {}
+    ]
+  },
+  {},
+  [1]
+);
+"
+`;
+
 exports[`should successfully bundle 2 feeds 1`] = `
 "(function e(t, n, r) {
   function s(o, u) {

test/reader.test.js

@@ -424,3 +424,60 @@ test('multiple entrypoints in same feed supported', async () => {
     expect(spy).toMatchSnapshot();
     expect(spy).toHaveBeenCalledTimes(4);
 });
+
+test('should replace NODE_ENV with default of "development"', async () => {
+    expect.hasAssertions();
+    const result = await bundleJS([
+        [
+            {
+                id: 'a',
+                entry: true,
+                file: './asdas.js',
+                source: 'console.log(process.env.NODE_ENV)',
+                deps: {},
+            },
+        ],
+    ]);
+    expect(result).toMatch('test');
+    expect(prettier.format(result)).toMatchSnapshot();
+});
+
+test('should replace NODE_ENV with process.env.NODE_ENV', async () => {
+    expect.hasAssertions();
+    const env = process.env.NODE_ENV;
+    process.env.NODE_ENV = 'production';
+    const result = await bundleJS([
+        [
+            {
+                id: 'a',
+                entry: true,
+                file: './asdas.js',
+                source: 'console.log(process.env.NODE_ENV)',
+                deps: {},
+            },
+        ],
+    ]);
+    expect(result).toMatch('production');
+    expect(prettier.format(result)).toMatchSnapshot();
+    process.env.NODE_ENV = env;
+});
+
+test('should replace NODE_ENV with given value', async () => {
+    expect.hasAssertions();
+    const result = await bundleJS(
+        [
+            [
+                {
+                    id: 'a',
+                    entry: true,
+                    file: './asdas.js',
+                    source: 'console.log(process.env.NODE_ENV)',
+                    deps: {},
+                },
+            ],
+        ],
+        { env: 'production' }
+    );
+    expect(result).toMatch('production');
+    expect(prettier.format(result)).toMatchSnapshot();
+});