Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Commit 9113289

Browse files
SimenBdigitalsadhu
authored andcommitted
test: add extra test asserting that unknown keys are allowed
1 parent e90832b commit 9113289

File tree

2 files changed

+21
-4
lines changed

2 files changed

+21
-4
lines changed

test/__snapshots__/reader.test.js.snap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58949,9 +58949,9 @@ exports[`should dedupe 1`] = `
5894958949
"
5895058950
`;
5895158951

58952-
exports[`should error if any feed content keys are missing 1`] = `"Expected at least 1 feed (array) to have more than one entry (object)."`;
58952+
exports[`should error if any feed content keys are missing 1`] = `"Expected every item in argument 'feeds' (array) to be a valid feed (object).: child \\"id\\" fails because [\\"id\\" is required]"`;
5895358953

58954-
exports[`should error if any feed content keys are missing 2`] = `"Expected at least 1 feed (array) to have more than one entry (object)."`;
58954+
exports[`should error if any feed content keys are missing 2`] = `"Expected every item in argument 'feeds' (array) to be a valid feed (object).: child \\"source\\" fails because [\\"source\\" is required]"`;
5895558955

5895658956
exports[`should error if feed content does not contain at least 1 entrypoint 1`] = `"Expected at least 1 feed (array) to have more than one entry (object)."`;
5895758957

test/reader.test.js

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,29 @@ test('should error if feed content is non object', async () => {
210210
});
211211

212212
test('should error if any feed content keys are missing', async () => {
213-
await expect(bundleJS([{}])).rejects.toThrowErrorMatchingSnapshot();
213+
await expect(bundleJS([[{}]])).rejects.toThrowErrorMatchingSnapshot();
214214
await expect(
215-
bundleJS([{ file: 'asd', deps: {}, id: 'a', entry: true }])
215+
bundleJS([[{ file: 'asd', deps: {}, id: 'a', entry: true }]])
216216
).rejects.toThrowErrorMatchingSnapshot();
217217
});
218218

219+
test('should not error if any feed contains extra content keys', async () => {
220+
await expect(
221+
bundleJS([
222+
[
223+
{
224+
file: 'asd',
225+
deps: {},
226+
id: 'a',
227+
entry: true,
228+
source: '"use strict";',
229+
somethingWeird: true,
230+
},
231+
],
232+
])
233+
).resolves.toBeDefined();
234+
});
235+
219236
test('should error if feed content does not contain at least 1 entrypoint', async () => {
220237
await expect(
221238
bundleJS([

0 commit comments

Comments
 (0)