Skip to content

Commit 414274d

Browse files
authored
Merge pull request #45 from assimp/bugfix/fix_build
Fix invalid test for a valid pointer
2 parents 084a701 + 35dc239 commit 414274d

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/ModelLoading.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ ModelLoadingApp::~ModelLoadingApp() {
5959
}
6060

6161
bool ModelLoadingApp::hasModel() const {
62-
return mModelNode.isValid();
62+
return mModelNode != nullptr;
6363
}
6464

6565
void ModelLoadingApp::pushIntention() {
@@ -256,4 +256,3 @@ void ModelLoadingApp::onUpdate() {
256256

257257
AppBase::onUpdate();
258258
}
259-

src/SceneData.h

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,17 +29,13 @@ struct aiScene;
2929
namespace AssimpViewer {
3030

3131
struct SceneData {
32-
std::string mAssetName;
33-
const aiScene *mScene;
32+
std::string mAssetName{"none"};
33+
const aiScene *mScene{nullptr};
3434

35-
SceneData();
35+
SceneData() = default;
3636
~SceneData() = default;
37+
SceneData(const SceneData &) = delete;
38+
SceneData &operator=(const SceneData &) = delete;
3739
};
3840

39-
inline SceneData::SceneData() :
40-
mAssetName("none"),
41-
mScene(nullptr) {
42-
// empty
43-
}
44-
4541
} // namespace AssimpViewer

0 commit comments

Comments
 (0)