fix: add more descriptive naming

HerringtonDarkholme · HerringtonDarkholme · commit 514f7c307a67 · 2025-03-16T10:07:52.000-04:00
diff --git a/src/extension/common.ts b/src/extension/common.ts
@@ -40,11 +40,12 @@ export function resolveBinary() {
 }
 
 export async function testBinaryExist(command: string) {
-  const _command = /\s/.test(command.trim()) ? `"${command}"` : command
+  // windows user may input space in command
+  const normalizedCommand = /\s/.test(command.trim()) ? `"${command}"` : command
   const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []
   return new Promise(r => {
     execFile(
-      _command,
+      normalizedCommand,
       ['-h'],
       {
         // for windows

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,12 @@ export function resolveBinary() {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`export async function testBinaryExist(command: string) {`
`43`		- const _command = /\s/.test(command.trim()) ? `"${command}"` : command
	`43`	`+ // windows user may input space in command`
	`44`	+ const normalizedCommand = /\s/.test(command.trim()) ? `"${command}"` : command
`44`	`45`	`const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []`
`45`	`46`	`return new Promise(r => {`
`46`	`47`	`execFile(`
`47`		`- _command,`
	`48`	`+ normalizedCommand,`
`48`	`49`	`['-h'],`
`49`	`50`	`{`
`50`	`51`	`// for windows`