fix: remove default command

HerringtonDarkholme · HerringtonDarkholme · commit 6fad78b96026 · 2024-03-20T21:29:41.000-07:00
diff --git a/package.json b/package.json
@@ -64,7 +64,6 @@
         "astGrep.serverPath": {
           "scope": "window",
           "type": "string",
-          "default": "ast-grep",
           "description": "Specify the language server binary path."
         },
         "astGrep.configPath": {
diff --git a/src/extension/common.ts b/src/extension/common.ts
@@ -32,7 +32,11 @@ export async function detectDefaultBinaryAtStart() {
 }
 
 export function resolveBinary() {
-  return workspace.getConfiguration('astGrep').get('serverPath', defaultBinary)
+  const config = workspace.getConfiguration('astGrep').get('serverPath', '')
+  if (!config) {
+    return defaultBinary
+  }
+  return config
 }
 
 export async function testBinaryExist(command: string) {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,11 @@ export async function detectDefaultBinaryAtStart() {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`export function resolveBinary() {`
`35`		`- return workspace.getConfiguration('astGrep').get('serverPath', defaultBinary)`
	`35`	`+ const config = workspace.getConfiguration('astGrep').get('serverPath', '')`
	`36`	`+ if (!config) {`
	`37`	`+ return defaultBinary`
	`38`	`+ }`
	`39`	`+ return config`
`36`	`40`	`}`
`37`	`41`
`38`	`42`	`export async function testBinaryExist(command: string) {`