fix: spawn shell option in windows (#235)

Closes #235

See incoming PR for detailed explanation

Author: tomchen

src/extension/common.ts

@@ -32,7 +32,10 @@ export async function detectDefaultBinaryAtStart() {
 }
 
 export function resolveBinary() {
-  const config = workspace.getConfiguration('astGrep').get('serverPath', '')
+  const config = workspace
+    .getConfiguration('astGrep')
+    .get('serverPath', '')
+    .trim()
   if (!config) {
     return defaultBinary
   }
@@ -41,15 +44,16 @@ export function resolveBinary() {
 
 export async function testBinaryExist(command: string) {
   // windows user may input space in command
-  const normalizedCommand = /\s/.test(command.trim()) ? `"${command}"` : command
+  const normalizedCommand =
+    /\s/.test(command) && !command.endsWith('.exe') ? `"${command}"` : command
   const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []
   return new Promise(r => {
     execFile(
       normalizedCommand,
       ['-h'],
       {
         // for windows
-        shell: process.platform === 'win32',
+        shell: process.platform === 'win32' && !command.endsWith('.exe'),
         cwd: uris[0],
       },
       err => {

src/extension/search.ts

@@ -114,6 +114,9 @@ export function buildCommand(query: SearchQuery) {
     return
   }
   const command = resolveBinary()
+  // windows user may input space in command
+  const normalizedCommand =
+    /\s/.test(command) && !command.endsWith('.exe') ? `"${command}"` : command
   const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []
   const args = ['run', '--pattern', pattern, '--json=stream']
   if (query.selector) {
@@ -135,9 +138,11 @@ export function buildCommand(query: SearchQuery) {
   } else {
     args.push(...validIncludeFile)
   }
-  console.debug('running', query, command, args)
+  console.debug('running', query, normalizedCommand, args)
   // TODO: multi-workspaces support
-  return spawn(command, args, {
+  return spawn(normalizedCommand, args, {
+    // for windows
+    shell: process.platform === 'win32' && !command.endsWith('.exe'),
     cwd: uris[0],
   })
 }