fix: testBinaryExist space

tomchen · HerringtonDarkholme · commit bc0f1d793bed · 2025-03-16T10:04:00.000-04:00
when command contains space, testBinaryExist() will fail, but the extension actually works
diff --git a/src/extension/common.ts b/src/extension/common.ts
@@ -40,10 +40,11 @@ export function resolveBinary() {
 }
 
 export async function testBinaryExist(command: string) {
+  const _command = /\s/.test(command.trim()) ? `"${command}"` : command
   const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []
   return new Promise(r => {
     execFile(
-      command,
+      _command,
       ['-h'],
       {
         // for windows

Original file line number	Diff line number	Diff line change
`@@ -40,10 +40,11 @@ export function resolveBinary() {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`export async function testBinaryExist(command: string) {`
	`43`	+ const _command = /\s/.test(command.trim()) ? `"${command}"` : command
`43`	`44`	`const uris = workspace.workspaceFolders?.map(i => i.uri?.fsPath) ?? []`
`44`	`45`	`return new Promise(r => {`
`45`	`46`	`execFile(`
`46`		`- command,`
	`47`	`+ _command,`
`47`	`48`	`['-h'],`
`48`	`49`	`{`
`49`	`50`	`// for windows`