feat: implement replaceAll without opening

Author: HerringtonDarkholme

src/extension/preview.ts

@@ -18,7 +18,6 @@ import {
   TextEditorRevealType,
   TabInputTextDiff,
   EventEmitter,
-  WorkspaceEdit,
 } from 'vscode'
 import type {
   ChildToParent,
@@ -182,9 +181,9 @@ parentPort.onMessage('previewDiff', previewDiff)
 parentPort.onMessage('dismissDiff', dismissDiff)
 parentPort.onMessage('search', refreshDiff)
 parentPort.onMessage('commitChange', onCommitChange)
-parentPort.onMessage('applyEdit', onApplyEdit)
+parentPort.onMessage('replaceAll', onReplaceAll)
 
-async function onApplyEdit(payload: ChildToParent['applyEdit']) {
+async function onReplaceAll(payload: ChildToParent['replaceAll']) {
   const confirmed = await window.showInformationMessage(
     'Replace all occurrences across all files?',
     { modal: true },
@@ -193,24 +192,14 @@ async function onApplyEdit(payload: ChildToParent['applyEdit']) {
   if (confirmed !== 'Replace') {
     return
   }
-  for (const { filePath, replacements } of payload) {
-    const workspaceEdit = new WorkspaceEdit()
-    const documentUri = workspaceUriFromFilePath(filePath)!
-
-    for (const { range, text } of replacements) {
-      workspaceEdit.replace(
-        documentUri,
-        new Range(
-          range.start.line,
-          range.start.column,
-          range.end.line,
-          range.end.column,
-        ),
-        text,
-      )
-    }
-    await workspace.applyEdit(workspaceEdit)
-    await workspace.save(documentUri)
+  const { id, inputValue, rewrite } = payload
+  for (const change of payload.changes) {
+    onCommitChange({
+      id,
+      inputValue,
+      rewrite,
+      ...change,
+    })
   }
 }
 

src/types.ts

@@ -98,13 +98,14 @@ export interface ChildToParent {
     inputValue: string
     rewrite: string
   }>
-  applyEdit: readonly {
-    filePath: string
-    replacements: readonly {
-      range: RangeInfo
-      text: string
+  replaceAll: WithId<{
+    inputValue: string
+    rewrite: string
+    changes: {
+      filePath: string
+      diffs: Diff[]
     }[]
-  }[]
+  }>
 }
 
 export type Definition = {

src/webview/SearchSidebar/SearchWidgetContainer/SearchWidget.tsx

@@ -4,7 +4,7 @@ import {
   refreshResult,
   hasInitialRewrite,
 } from '../../hooks/useQuery'
-import { useSearchResult, replaceAll } from '../../hooks/useSearch'
+import { useSearchResult, acceptAllChanges } from '../../hooks/useSearch'
 import { SearchInput } from './SearchInput'
 import { useBoolean } from 'react-use'
 import { VscChevronRight, VscChevronDown, VscReplaceAll } from 'react-icons/vsc'
@@ -62,7 +62,7 @@ function ReplaceBar() {
         title="Replace All"
         appearance="icon"
         disabled={disabled}
-        onClick={replaceAll}
+        onClick={acceptAllChanges}
         {...stylex.props(styles.replaceAll)}
       >
         <VscReplaceAll />

src/webview/hooks/useSearch.tsx

@@ -7,7 +7,7 @@ import {
   commitChange,
   childPort,
   type RangeInfo,
-  applyEdit,
+  replaceAll,
 } from '../postMessage'
 import { useSyncExternalStore } from 'react'
 import type { SearchQuery } from './useQuery'
@@ -217,16 +217,16 @@ export function acceptFileChanges(filePath: string) {
 /**
  * Replace all matches in the search results
  */
-export function replaceAll() {
-  applyEdit(
-    grouped.map(([filePath, diffs]) => ({
-      filePath,
-      replacements: diffs.map(d => ({
-        range: d.range,
-        text: d.replacement!,
-      })),
-    })),
-  )
+export function acceptAllChanges() {
+  const changes = grouped.map(([filePath, diffs]) => ({
+    filePath,
+    diffs: diffs.map(d => ({ replacement: d.replacement!, range: d.range })),
+  }))
+  replaceAll({
+    id,
+    ...queryInFlight,
+    changes,
+  })
 }
 
 export function dismissOneMatch(match: DisplayResult) {

src/webview/postMessage.ts

@@ -35,6 +35,6 @@ export function commitChange(diff: ChildToParent['commitChange']) {
   childPort.postMessage('commitChange', diff)
 }
 
-export function applyEdit(payload: ChildToParent['applyEdit']) {
-  childPort.postMessage('applyEdit', payload)
+export function replaceAll(payload: ChildToParent['replaceAll']) {
+  childPort.postMessage('replaceAll', payload)
 }