Skip to content

Commit 70f4fbf

Browse files
ajdapretnarastaric
authored andcommitted
Merge pull request biolab#1840 from janezd/scatter-no-report-empty
[FIX] Scatter plot: don't crash on report without data (cherry picked from commit d098ccb)
1 parent 45b2451 commit 70f4fbf

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

Orange/widgets/visualize/owscatterplot.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,8 @@ def get_widget_name_extension(self):
494494
return "{} vs {}".format(self.attr_x.name, self.attr_y.name)
495495

496496
def send_report(self):
497+
if self.data is None:
498+
return
497499
def name(var):
498500
return var and var.name
499501
caption = report.render_items_vert((

Orange/widgets/visualize/tests/test_owscatterplot.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Test methods with long descriptive names can omit docstrings
22
# pylint: disable=missing-docstring
3+
from unittest.mock import MagicMock
4+
35
import numpy as np
46

57
from AnyQt.QtCore import QRectF
@@ -91,3 +93,12 @@ def test_error_message(self):
9193
self.assertTrue(self.widget.Warning.missing_coords.is_shown())
9294
self.send_signal("Data", None)
9395
self.assertFalse(self.widget.Warning.missing_coords.is_shown())
96+
97+
def test_report_on_empty(self):
98+
self.widget.report_plot = MagicMock()
99+
self.widget.report_caption = MagicMock()
100+
self.widget.report_items = MagicMock()
101+
self.widget.send_report() # Essentially, don't crash
102+
self.widget.report_plot.assert_not_called()
103+
self.widget.report_caption.assert_not_called()
104+
self.widget.report_items.assert_not_called()

0 commit comments

Comments
 (0)