Skip to content

Commit d39c89e

Browse files
lanzagarastaric
authored andcommitted
Merge pull request biolab#1912 from VesnaT/fix_mosaic
[FIX] OWMosaic: Discretize metas as well (cherry picked from commit 3e6e181)
1 parent 5381571 commit d39c89e

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

Orange/widgets/visualize/owmosaic.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,8 @@ def set_data(self, data):
404404
self.discrete_data = None
405405
elif any(attr.is_continuous for attr in data.domain):
406406
self.discrete_data = Discretize(
407-
method=EqualFreq(n=4), discretize_classes=True)(data)
407+
method=EqualFreq(n=4), discretize_classes=True,
408+
discretize_metas=True)(data)
408409
else:
409410
self.discrete_data = self.data
410411

Orange/widgets/visualize/tests/test_owmosaic.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
# Test methods with long descriptive names can omit docstrings
22
# pylint: disable=missing-docstring
3+
import numpy as np
4+
35
from AnyQt.QtCore import QEvent, QPoint, Qt
46
from AnyQt.QtGui import QMouseEvent
57

6-
from Orange.data import Table, DiscreteVariable, Domain
8+
from Orange.data import Table, DiscreteVariable, Domain, ContinuousVariable
79
from Orange.widgets.tests.base import WidgetTest, WidgetOutputsTestMixin
810
from Orange.widgets.visualize.owmosaic import OWMosaicDisplay, MosaicVizRank
911

@@ -26,6 +28,14 @@ def _select_data(self):
2628
Qt.LeftButton, Qt.KeyboardModifiers()))
2729
return [2, 3, 9, 23, 29, 30, 34, 35, 37, 42, 47, 49]
2830

31+
def test_continuous_metas(self):
32+
"""Check widget for dataset with continuous metas"""
33+
domain = Domain([ContinuousVariable("c1")],
34+
metas=[ContinuousVariable("m")])
35+
data = Table(domain, np.arange(6).reshape(6, 1),
36+
metas=np.arange(6).reshape(6, 1))
37+
self.send_signal("Data", data)
38+
2939

3040
# Derive from WidgetTest to simplify creation of the Mosaic widget, although
3141
# we are actually testing the MosaicVizRank dialog and not the widget

0 commit comments

Comments
 (0)