Included samples #100
-
|
Why are currently the sample responses in the deployment branch? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
I wasn't around when they were written but as the deployment branch is just a copy of the master branch it was published with the PR that added these tests. |
Beta Was this translation helpful? Give feedback.
-
|
i think long term we should clean the deployment branch from hacky development stuff like this |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, that's another task that's yet to complete. |
Beta Was this translation helpful? Give feedback.
-
|
I just noticed the same for unfinished modules with commented code in them. IMO thats what feature branches are for. Would it generally be possible to either clean out the branches and remove unused ones / to merge them or document them properly? Also i think it would be a good long term goal to free the main branch of hacky production code / code snippets / samples and such. Prime example is probably rubsignin_page.dart or one of the example mensa repsonses or the usage of print in production code. Maybe the maintainers can setup some contribution guideliens / general guidelines for this |
Beta Was this translation helpful? Give feedback.
I wasn't around when they were written but as the deployment branch is just a copy of the master branch it was published with the PR that added these tests.