Display better error messages when log and exec requests fail

Author: astefanutti

docs/kubebox.js

@@ -2575,9 +2575,20 @@ class Dashboard {
 
       until(promise)
         .spin(s => exec.setLabel(`${s} ${namespace}/${name}/${container}`))
+        .catch(error => {
+          exec.setLabel(`${namespace}/${name}/${container}`);
+          exec.terminal.write(`\x1b[31m${error}\x1b[m\r\n`);
+          exec.terminal.write('Type Ctrl-C to close\r\n');
+          exec.terminal.once('key C-c', () => {
+            exec.terminal.dispose();
+            navbar.remove(byId);
+          });
+          return Promise.reject();
+        })
         .then(() => debug.log(`{grey-fg}Remote shell into '${namespace}/${name}/${container}'{/grey-fg}`))
         .then(() => exec.setLabel(`${namespace}/${name}/${container}`))
         .then(() => {
+          // TODO: add retry on timeout
           const { promise, cancellation } = get(client.watch_pod(namespace, name, pod.metadata.resourceVersion), { generator: function* () {
             let change;
             while (change = yield) {
@@ -2600,8 +2611,9 @@ class Dashboard {
           cancellations.add(watch, cancellation);
           return promise;
         })
-        // TODO: display error details in terminal
-        .catch(error => console.error(error.stack));
+        .catch(error => {
+          if (error) console.error(error.stack);
+        });
     });
 
     pods_table.on('select', (item, i) => {
@@ -2705,12 +2717,19 @@ class Dashboard {
       until(logs.promise)
         .spin(s => pod_log.setLabel(`${s} Logs {grey-fg}[${container.name}]{/grey-fg}`))
         .cancel(c => cancellations.add('dashboard.pod.logs', c))
+        .catch(error => {
+          pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg}`);
+          pod_log.log(`\x1b[31mError: ${error.message}\x1b[m`);
+          return Promise.reject();
+        })
         .then(() => debug.log(`{grey-fg}Following log for ${name}/${container.name} ...{/grey-fg}`))
         .then(() => k8s.isPodTerminating(getPodByUid(pod.metadata.uid))
           ? pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg} {red-fg}TERMINATING{/red-fg}`)
           : pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg}`))
         .then(() => screen.render())
-        .catch(error => console.error(error.stack));
+        .catch(error => {
+          if (error) console.error(error.stack);
+        });
 
       const stats = updateStatsFromCAdvisor(pod, container);
       cancellations.add('dashboard.pod.stats', stats.cancellation);
@@ -3050,6 +3069,7 @@ class Exec extends Duplex {
         }
       },
     });
+    this.terminal = terminal;
 
     const browserCopyToClipboard = function (event) {
       if (terminal.hasSelection()) {

lib/ui/dashboard.js

@@ -183,9 +183,20 @@ class Dashboard {
 
       until(promise)
         .spin(s => exec.setLabel(`${s} ${namespace}/${name}/${container}`))
+        .catch(error => {
+          exec.setLabel(`${namespace}/${name}/${container}`);
+          exec.terminal.write(`\x1b[31m${error}\x1b[m\r\n`);
+          exec.terminal.write('Type Ctrl-C to close\r\n');
+          exec.terminal.once('key C-c', () => {
+            exec.terminal.dispose();
+            navbar.remove(byId);
+          });
+          return Promise.reject();
+        })
         .then(() => debug.log(`{grey-fg}Remote shell into '${namespace}/${name}/${container}'{/grey-fg}`))
         .then(() => exec.setLabel(`${namespace}/${name}/${container}`))
         .then(() => {
+          // TODO: add retry on timeout
           const { promise, cancellation } = get(client.watch_pod(namespace, name, pod.metadata.resourceVersion), { generator: function* () {
             let change;
             while (change = yield) {
@@ -208,8 +219,9 @@ class Dashboard {
           cancellations.add(watch, cancellation);
           return promise;
         })
-        // TODO: display error details in terminal
-        .catch(error => console.error(error.stack));
+        .catch(error => {
+          if (error) console.error(error.stack);
+        });
     });
 
     pods_table.on('select', (item, i) => {
@@ -313,12 +325,19 @@ class Dashboard {
       until(logs.promise)
         .spin(s => pod_log.setLabel(`${s} Logs {grey-fg}[${container.name}]{/grey-fg}`))
         .cancel(c => cancellations.add('dashboard.pod.logs', c))
+        .catch(error => {
+          pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg}`);
+          pod_log.log(`\x1b[31mError: ${error.message}\x1b[m`);
+          return Promise.reject();
+        })
         .then(() => debug.log(`{grey-fg}Following log for ${name}/${container.name} ...{/grey-fg}`))
         .then(() => k8s.isPodTerminating(getPodByUid(pod.metadata.uid))
           ? pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg} {red-fg}TERMINATING{/red-fg}`)
           : pod_log.setLabel(`Logs {grey-fg}[${container.name}]{/grey-fg}`))
         .then(() => screen.render())
-        .catch(error => console.error(error.stack));
+        .catch(error => {
+          if (error) console.error(error.stack);
+        });
 
       const stats = updateStatsFromCAdvisor(pod, container);
       cancellations.add('dashboard.pod.stats', stats.cancellation);

lib/ui/exec.js

@@ -46,6 +46,7 @@ class Exec extends Duplex {
         }
       },
     });
+    this.terminal = terminal;
 
     const browserCopyToClipboard = function (event) {
       if (terminal.hasSelection()) {