Support dumping more memory pages: SFF8472(A0h & A2h), SFF8436 & SFF8636(Lower Page 00h, Upper Page 00h - 03h), CMIS(Lower Memory, Page 00h - 04h.)

Author: hangtsi

drivers/src/bf_qsfp/bf_sfp_comm.c

@@ -184,7 +184,7 @@ bool bf_sfp_get_dom_support (int port)
 */
 bool bf_sfp_is_present (int port)
 {
-    if (port < 0 || port > bf_plt_max_sfp) {
+    if (port > bf_plt_max_sfp) {
         return false;
     }
     return bf_sfp_info_arr[port].present;
@@ -603,7 +603,7 @@ int bf_sfp_update_cache (int port)
 
 static bf_sfp_info_t *bf_sfp_get_info (int port)
 {
-    if (port < 0 || port > bf_plt_max_sfp) {
+    if (port > bf_plt_max_sfp) {
         return NULL;
     }
 

platforms/asterfusion-bf/include/bf_mav_led.h

@@ -67,9 +67,6 @@ typedef void (*led_convert_fun_ptr) (bf_led_condition_t,
 /* Light on/off LOC LED */
 int bf_pltfm_location_led_set (int on_off);
 
-/* Light on/off LOC LED */
-int bf_pltfm_location_led_set (int on_off);
-
 #ifdef INC_PLTFM_UCLI
 ucli_node_t *bf_pltfm_led_ucli_node_create (
     ucli_node_t *m);

platforms/asterfusion-bf/src/platform_mgr/platform_health_mntr.c

@@ -410,7 +410,7 @@ static void bf_pltfm_onlp_mntr_transceiver()
     int module;
     int max_sfp_modules;
     int max_qsfp_modules;
-    uint8_t buf[MAX_QSFP_PAGE_SIZE * 4] = {0};
+    uint8_t buf[MAX_QSFP_PAGE_SIZE * 6] = {0};
     uint32_t flags = bf_pltfm_mgr_ctx()->flags;
 
     struct qsfp_ctx_t *qsfp, *qsfp_ctx;
@@ -491,6 +491,14 @@ static void bf_pltfm_onlp_mntr_transceiver()
             }
         }
 
+        
+        /* Providing limited memory pages should be enough since
+           the claim is only for DDM information.
+           SFF8436 & SFF8636: LP00h + UP(00-03)h, 128 * 5
+           CMIS: LM + P(00-04)h, 128 * 6
+           Thus we need a buffer of at least size 128 * 6.
+           By SunZheng, 2025/04/11.
+        */
         if (bf_qsfp_get_cached_info (i,
                 QSFP_PAGE0_LOWER, buf)) {
             continue;
@@ -500,13 +508,33 @@ static void bf_pltfm_onlp_mntr_transceiver()
                 buf + MAX_QSFP_PAGE_SIZE)) {
             continue;
         }
-#if 0
-        if (bf_qsfp_is_cmis (i)) {
+        if (bf_qsfp_get_cached_info (
+                i, QSFP_PAGE1,
+                buf + MAX_QSFP_PAGE_SIZE * 2)) {
             continue;
         }
-#endif
-        onlp_save (path, (char *)buf,
-                   MAX_QSFP_PAGE_SIZE * 2);
+        if (bf_qsfp_get_cached_info (
+                i, QSFP_PAGE2,
+                buf + MAX_QSFP_PAGE_SIZE * 3)) {
+            continue;
+        }
+        if (bf_qsfp_get_cached_info (
+                i, QSFP_PAGE3,
+                buf + MAX_QSFP_PAGE_SIZE * 4)) {
+            continue;
+        }
+        if (bf_qsfp_is_cmis (i)) {
+            if (bf_qsfp_get_cached_info (
+                    i, QSFP_PAGE4,
+                    buf + MAX_QSFP_PAGE_SIZE * 5)) {
+                continue;
+            }
+            onlp_save (path, (char *)buf,
+                       MAX_QSFP_PAGE_SIZE * 6);
+        } else {
+            onlp_save (path, (char *)buf,
+                       MAX_QSFP_PAGE_SIZE * 5);
+        }
     }
     sprintf (path, ONLP_LOG_QSFP_PRES_PATH,
              "presence");
@@ -573,12 +601,12 @@ static void bf_pltfm_onlp_mntr_transceiver()
             continue;
         }
         if (bf_sfp_get_cached_info (i, 1,
-                                    buf + 2 * MAX_QSFP_PAGE_SIZE) ) {
+                                    buf + MAX_QSFP_PAGE_SIZE) ) {
             continue;
         }
         /* $ hexdump /var/asterfusion/qsfp_10_eeprom is helpful. */
         onlp_save (path, (char *)buf,
-                   MAX_QSFP_PAGE_SIZE * 4);
+                   MAX_QSFP_PAGE_SIZE * 2);
     }
     sprintf (path, ONLP_LOG_SFP_PRES_PATH,
              "presence");