Escape Pattern before being passed to glob

Author: rcoh

src/lib.rs

@@ -91,7 +91,7 @@ use std::env;
 use std::path::PathBuf;
 use std::process::Command;
 
-use glob::glob;
+use glob::{glob, Pattern};
 use lazy_static::lazy_static;
 
 pub mod errors;
@@ -252,7 +252,7 @@ pub fn locate_file(file_name: &str) -> errors::Result<String> {
     // Find the JAVA_HOME
     let java_home = locate_java_home()?;
 
-    let query = format!("{}/**/{}", java_home, file_name);
+    let query = format!("{}/**/{}", Pattern::escape(&java_home), file_name);
 
     let paths_vec: Vec<String> = glob(&query)?
         .filter_map(Result::ok)

tests/[funky-javahome]/nested/more*nested/libjvm.dll

@@ -0,0 +1 @@
+# test file for windows

tests/[funky-javahome]/nested/more*nested/libjvm.so

@@ -0,0 +1 @@
+# Test file for unix 

tests/ensure-escaped.rs

@@ -0,0 +1,11 @@
+use java_locator::locate_jvm_dyn_library;
+
+#[test]
+fn test_javahome_can_be_escaped() {
+    println!("{:?}", std::env::current_dir());
+    std::env::set_var("JAVA_HOME", "tests/[funky-javahome]/nested");
+    assert_eq!(
+        locate_jvm_dyn_library().expect("failed to located jvm library"),
+        "tests/[funky-javahome]/nested/more*nested"
+    );
+}