Skip to content

Commit 33c3d72

Browse files
committed
unix: add CoreFoundation as tkinter dependency
libtcl and libtk link against it. And since we don't pick up the transitive framework dependencies of library dependencies, we need to annotate them as extra linker arguments in the modules files. See indygreg/PyOxidizer#380 (comment).
1 parent aab7039 commit 33c3d72

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

cpython-unix/static-modules.3.8.macos

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ _queue _queuemodule.c
2828
_scproxy _scproxy.c -framework SystemConfiguration -framework CoreFoundation
2929
_sqlite3 _sqlite/cache.c _sqlite/connection.c _sqlite/cursor.c _sqlite/microprotocols.c _sqlite/module.c _sqlite/prepare_protocol.c _sqlite/row.c _sqlite/statement.c _sqlite/util.c -IModules/_sqlite -DMODULE_NAME=\"sqlite3\" -DSQLITE_OMIT_LOAD_EXTENSION=1 -lsqlite3
3030
_ssl _ssl.c -lssl -lcrypto
31-
_tkinter _tkinter.c tkappinit.c -DWITH_APPINIT -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreServices -framework CoreGraphics -framework IOKit -ltcl8.6 -ltk8.6
31+
# CoreFoundation isn't a directory dependency but is a dependency of libtcl and libtk.
32+
_tkinter _tkinter.c tkappinit.c -DWITH_APPINIT -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework CoreServices -framework CoreGraphics -framework IOKit -ltcl8.6 -ltk8.6
3233
_uuid _uuidmodule.c -luuid
3334
pyexpat pyexpat.c expat/xmlparse.c expat/xmlrole.c expat/xmltok.c -DHAVE_EXPAT_CONFIG_H=1 -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI -IModules/expat
3435
readline readline.c -ledit -lncurses

cpython-unix/static-modules.3.9.macos

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ _testbuffer _testbuffer.c
3333
_testimportmultiple _testimportmultiple.c
3434
_testinternalcapi _testinternalcapi.c -DPy_BUILD_CORE_MODULE
3535
_testmultiphase _testmultiphase.c
36-
_tkinter _tkinter.c tkappinit.c -DWITH_APPINIT -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreServices -framework CoreGraphics -framework IOKit -ltcl8.6 -ltk8.6
36+
# CoreFoundation isn't a directory dependency but is a dependency of libtcl and libtk.
37+
_tkinter _tkinter.c tkappinit.c -DWITH_APPINIT -framework AppKit -framework ApplicationServices -framework Carbon -framework CoreFoundation -framework CoreServices -framework CoreGraphics -framework IOKit -ltcl8.6 -ltk8.6
3738
_uuid _uuidmodule.c -luuid
3839
_xxsubinterpreters _xxsubinterpretersmodule.c
3940
_xxtestfuzz _xxtestfuzz/_xxtestfuzz.c _xxtestfuzz/fuzzer.c

0 commit comments

Comments
 (0)