unix: do not built _test_ctypes as a built-in on macOS

We now build a .so file and test_ctypes now passes on macOS!

As part of this, since there is a lib-dynload directory in the output,
we make the creation of this directory conditional so we don't ship
a .empty file if it isn't needed.

Author: indygreg

cpython-unix/build-cpython.sh

@@ -272,8 +272,11 @@ fi
 find ${ROOT}/out/python/install -type d -name __pycache__ -print0 | xargs -0 rm -rf
 
 # Ensure lib-dynload exists, or Python complains on startup.
-mkdir -p ${ROOT}/out/python/install/lib/python${PYTHON_MAJMIN_VERSION}/lib-dynload
-touch ${ROOT}/out/python/install/lib/python${PYTHON_MAJMIN_VERSION}/lib-dynload/.empty
+LIB_DYNLOAD=${ROOT}/out/python/install/lib/python${PYTHON_MAJMIN_VERSION}/lib-dynload
+if [ ! -d ${LIB_DYNLOAD} ]; then
+  mkdir -p ${LIB_DYNLOAD}
+  touch ${LIB_DYNLOAD}/.empty
+fi
 
 # Symlink libpython so we don't have 2 copies. We only need to do
 # this on Python 3.7, as 3.8 dropped the m ABI suffix from binary names.

cpython-unix/static-modules.3.7.macos

@@ -8,7 +8,6 @@ _crypt _cryptmodule.c
 _curses _cursesmodule.c -lncurses
 _curses_panel _curses_panel.c -lpanel -lncurses
 _ctypes _ctypes/_ctypes.c _ctypes/callbacks.c _ctypes/callproc.c _ctypes/darwin/dlfcn_simple.c _ctypes/malloc_closure.c _ctypes/stgdict.c _ctypes/cfield.c -DMACOSX -I_ctypes/darwin -lffi -ldl
-_ctypes_test _ctypes/_ctypes_test.c -lm
 _decimal _decimal/_decimal.c _decimal/libmpdec/basearith.c _decimal/libmpdec/constants.c _decimal/libmpdec/context.c _decimal/libmpdec/convolute.c _decimal/libmpdec/crt.c _decimal/libmpdec/difradix2.c _decimal/libmpdec/fnt.c _decimal/libmpdec/fourstep.c _decimal/libmpdec/io.c _decimal/libmpdec/memory.c _decimal/libmpdec/mpdecimal.c _decimal/libmpdec/numbertheory.c _decimal/libmpdec/sixstep.c _decimal/libmpdec/transpose.c -DUNIVERSAL=1 -IModules/_decimal/libmpdec
 _dbm _dbmmodule.c -DHAVE_BERKDB_H -DDB_DBM_HSEARCH -ldb
 _elementtree _elementtree.c -DHAVE_EXPAT_CONFIG_H=1 -DXML_POOR_ENTROPY=1 -DUSE_PYEXPAT_CAPI -IModules/expat

docs/status.rst

@@ -28,7 +28,7 @@ Here, we track the various known failures when running
 ``test_ctypes``
 ---------------
 
-Known Failing on: Linux, macOS
+Known Failing on: Linux
 
 This fails with a bunch of
 ``AttributeError: module '_ctypes_test' has no attribute '__file__'``.