Skip to content

Commit 3fe9cb9

Browse files
committed
windows: filter out static extensions before checking for presence
Otherwise static can fail if ignore_static is set but ignore_missing isn't.
1 parent 5286109 commit 3fe9cb9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

cpython-windows/build.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,16 +1598,16 @@ def collect_python_build_artifacts(
15981598
dirs = {p for p in os.listdir(intermediates_path)}
15991599

16001600
for extension, entry in CONVERT_TO_BUILTIN_EXTENSIONS.items():
1601+
if static and entry.get("ignore_static"):
1602+
continue
1603+
16011604
if extension not in dirs:
16021605
if entry.get("ignore_missing"):
16031606
continue
16041607
else:
16051608
log("extension not present: %s" % extension)
16061609
sys.exit(1)
16071610

1608-
if static and entry.get("ignore_static"):
1609-
continue
1610-
16111611
extension_projects.add(extension)
16121612
if static:
16131613
depends_projects |= set(entry.get("static_depends", []))

0 commit comments

Comments
 (0)