windows: use Strawberry Perl for build

This avoids requiring a pre-installed Perl and a custom environment
variable.

Author: uranusjr

README.rst

@@ -56,9 +56,7 @@ To build a Python distribution for macOS::
 
 To build a Python distribution for Windows x64::
 
-   # Install ActivePerl
    # From a Visual Studio 2017 x64 native tools command prompt:
-   $ set PERL=c:\path\to\activeperl\bin\perl.exe
    $ py.exe build-windows.py
 
 Requirements
@@ -87,9 +85,8 @@ exist, try running the installer. e.g.::
 Windows
 -------
 
-Visual Studio 2017 (or later) is required.
-
-ActivePerl must be installed.
+Visual Studio 2017 (or later) is required. A compatible Windows SDK is required
+(10.0.17763.0 as per CPython 3.7.2).
 
 How It Works
 ============

build-windows.py

@@ -56,10 +56,6 @@ def run():
 
 
 if __name__ == '__main__':
-    if 'PERL' not in os.environ:
-        print('PERL must point to a perl executable')
-        sys.exit(1)
-
     try:
         if 'PYBUILD_BOOTSTRAPPED' not in os.environ:
             bootstrap()

cpython-windows/build.py

@@ -12,6 +12,7 @@
 import subprocess
 import sys
 import tempfile
+import zipfile
 
 from pythonbuild.downloads import (
     DOWNLOADS,
@@ -928,7 +929,6 @@ def build_openssl_for_arch(perl_path, arch: str, openssl_archive, nasm_archive,
     openssl_version = DOWNLOADS['openssl']['version']
     nasm_version = DOWNLOADS['nasm-windows-bin']['version']
 
-
     log('extracting %s to %s' % (openssl_archive, build_root))
     extract_tar_to_directory(openssl_archive, build_root)
     log('extracting %s to %s' % (nasm_archive, build_root))
@@ -1227,7 +1227,6 @@ def build_cpython(pgo=False):
     # The python.props file keys off MSBUILD, so it needs to be set.
     os.environ['MSBUILD'] = str(msbuild)
 
-    activeperl_installer = download_entry('activeperl', BUILD)
     bzip2_archive = download_entry('bzip2', BUILD)
     sqlite_archive = download_entry('sqlite', BUILD)
     tk_bin_archive = download_entry('tk-windows-bin', BUILD, local_name='tk-windows-bin.tar.gz')
@@ -1373,6 +1372,15 @@ def build_cpython(pgo=False):
             create_tar_from_directory(fh, td / 'out')
 
 
+def fetch_strawberry_perl() -> pathlib.Path:
+    strawberryperl_zip = download_entry('strawberryperl', BUILD)
+    strawberryperl = BUILD / 'strawberry-perl'
+    strawberryperl.mkdir(exist_ok=True)
+    with zipfile.ZipFile(strawberryperl_zip) as zf:
+        zf.extractall(strawberryperl)
+    return strawberryperl
+
+
 def main():
     BUILD.mkdir(exist_ok=True)
 
@@ -1384,8 +1392,9 @@ def main():
         # TODO need better dependency checking.
         openssl_out = BUILD / 'openssl-windows.tar'
         if not openssl_out.exists():
+            perl_path = fetch_strawberry_perl() / 'perl' / 'bin' / 'perl.exe'
             LOG_PREFIX[0] = 'openssl'
-            build_openssl(pathlib.Path(os.environ['PERL']))
+            build_openssl(perl_path)
 
         LOG_PREFIX[0] = 'cpython'
         build_cpython()

pythonbuild/downloads.py

@@ -3,12 +3,6 @@
 # file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 DOWNLOADS = {
-    'activeperl': {
-        'url': 'https://downloads.activestate.com/ActivePerl/releases/5.26.3.2603/ActivePerl-5.26.3.2603-MSWin32-x64-a95bce075.exe',
-        'size': 22429768,
-        'sha256': 'bbd88265ab6d0ceb5ec2a6cd9870b0e9cd35b0d9be7671df840b0f239726b28d',
-        'version': '5.26.3.2603',
-    },
     # 6.0.19 is the last version licensed under the Sleepycat license.
     'bdb': {
         'url': 'https://ftp.tw.freebsd.org/distfiles/bdb/db-6.0.19.tar.gz',
@@ -225,6 +219,12 @@
         'version': '3260000',
         'actual_version': '3.26.0.0',
     },
+    'strawberryperl': {
+        'url': 'http://strawberryperl.com/download/5.28.1.1/strawberry-perl-5.28.1.1-32bit-portable.zip',
+        'size': 143242779,
+        'sha256': '8b15c7c9574989568254a7859e473b7d5f68a1145d2e4418036600a81b13805c',
+        'version': '5.28.1.1',
+    },
     'tcl': {
         'url': 'https://prdownloads.sourceforge.net/tcl/tcl8.6.9-src.tar.gz',
         'size': 10000896,