Skip to content

Commit 59be8b3

Browse files
committed
pythonbuild: extract tarballs as build user
I'm not sure why we were forcing use of the root user here. Maybe a holdover from prior code? Writing the files as the build user enables jobs to modify their content, which can be desirable for patching these files in individual builds. Impetus for this is I want to add a `cc` symlink for `clang` so the compiler gets reported as `cc` and not `clang`. This change only impacts container builds. Since those are reproducible, I want to say this is safe if it passes CI.
1 parent 80cd87f commit 59be8b3

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pythonbuild/buildenv.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def install_toolchain_archive(self, build_dir, package_name, host_platform):
4444

4545
p = build_dir / basename
4646
self.copy_file(p)
47-
self.run(["/bin/tar", "-C", "/tools", "-xf", "/build/%s" % p.name], user="root")
47+
self.run(["/bin/tar", "-C", "/tools", "-xf", "/build/%s" % p.name])
4848

4949
def install_artifact_archive(
5050
self, build_dir, package_name, target_triple, optimizations
@@ -60,7 +60,7 @@ def install_artifact_archive(
6060
p = build_dir / basename
6161

6262
self.copy_file(p)
63-
self.run(["/bin/tar", "-C", "/tools", "-xf", "/build/%s" % p.name], user="root")
63+
self.run(["/bin/tar", "-C", "/tools", "-xf", "/build/%s" % p.name])
6464

6565
def install_toolchain(
6666
self,

0 commit comments

Comments
 (0)