Skip to content

Commit 774b41c

Browse files
committed
windows: make --sh a required argument
It is required for Python 3.8+, which are the only versions of Python we support building.
1 parent 774fb47 commit 774b41c

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

cpython-windows/build.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2408,14 +2408,12 @@ def main():
24082408
default="static-noopt",
24092409
help="How to compile Python",
24102410
)
2411-
parser.add_argument("--sh", help="Path to sh.exe in a cygwin or mingw installation")
2411+
parser.add_argument(
2412+
"--sh", required=True, help="Path to sh.exe in a cygwin or mingw installation"
2413+
)
24122414

24132415
args = parser.parse_args()
24142416

2415-
if args.python in ("cpython-3.8", "cpython-3.9") and not args.sh:
2416-
print("--sh required when building Python 3.8+")
2417-
return 1
2418-
24192417
log_path = BUILD / "build.log"
24202418

24212419
with log_path.open("wb") as log_fh:

0 commit comments

Comments
 (0)