unix: remove LIBTOOL_CRUFT from configure

This is dead code and breaks macOS aarch64 -> x86_64 cross-compilation.

Closes #150.

Author: indygreg

cpython-unix/build-cpython.sh

@@ -134,6 +134,10 @@ else
     patch -p1 -i ${ROOT}/patch-xopen-source-ios-legacy.patch
 fi
 
+# LIBTOOL_CRUFT is unused and breaks cross-compiling on macOS. Nuke it.
+# Submitted upstream at https://github.com/python/cpython/pull/101048.
+patch -p1 -i ${ROOT}/patch-configure-remove-libtool-cruft.patch
+
 # Configure nerfs RUNSHARED when cross-compiling, which prevents PGO from running when
 # we can in fact run the target binaries (e.g. x86_64 host and i686 target). Undo that.
 if [ -n "${CROSS_COMPILING}" ]; then

cpython-unix/patch-configure-remove-libtool-cruft.patch

@@ -0,0 +1,77 @@
+diff --git a/configure.ac b/configure.ac
+index 956334a865..d5f4aed476 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -2970,72 +2970,6 @@ case $ac_sys_system/$ac_sys_release in
+     ;;
+ esac
+ 
+-
+-AC_SUBST(LIBTOOL_CRUFT)
+-case $ac_sys_system/$ac_sys_release in
+-  Darwin/@<:@01567@:>@\..*)
+-    LIBTOOL_CRUFT="-framework System -lcc_dynamic"
+-    if test "${enable_universalsdk}"; then
+-	    :
+-    else
+-        LIBTOOL_CRUFT="${LIBTOOL_CRUFT} -arch_only `/usr/bin/arch`"
+-    fi
+-    LIBTOOL_CRUFT=$LIBTOOL_CRUFT' -install_name $(PYTHONFRAMEWORKINSTALLDIR)/Versions/$(VERSION)/$(PYTHONFRAMEWORK)'
+-    LIBTOOL_CRUFT=$LIBTOOL_CRUFT' -compatibility_version $(VERSION) -current_version $(VERSION)';;
+-  Darwin/*)
+-    gcc_version=`gcc -dumpversion`
+-    if test ${gcc_version} '<' 4.0
+-        then
+-            LIBTOOL_CRUFT="-lcc_dynamic"
+-        else
+-            LIBTOOL_CRUFT=""
+-    fi
+-    AC_RUN_IFELSE([AC_LANG_SOURCE([[
+-    #include <unistd.h>
+-    int main(int argc, char*argv[])
+-    {
+-      if (sizeof(long) == 4) {
+-    	  return 0;
+-      } else {
+-      	  return 1;
+-      }
+-    }
+-    ]])],[ac_osx_32bit=yes],[ac_osx_32bit=no],[ac_osx_32bit=yes])
+-
+-    if test "${ac_osx_32bit}" = "yes"; then
+-    	case `/usr/bin/arch` in
+-    	i386)
+-    		MACOSX_DEFAULT_ARCH="i386"
+-    		;;
+-    	ppc)
+-    		MACOSX_DEFAULT_ARCH="ppc"
+-    		;;
+-    	*)
+-    		AC_MSG_ERROR([Unexpected output of 'arch' on macOS])
+-    		;;
+-    	esac
+-    else
+-    	case `/usr/bin/arch` in
+-    	i386)
+-    		MACOSX_DEFAULT_ARCH="x86_64"
+-    		;;
+-    	ppc)
+-    		MACOSX_DEFAULT_ARCH="ppc64"
+-		;;
+-    	arm64)
+-    		MACOSX_DEFAULT_ARCH="arm64"
+-    		;;
+-    	*)
+-    		AC_MSG_ERROR([Unexpected output of 'arch' on macOS])
+-    		;;
+-    	esac
+-
+-    fi
+-
+-    LIBTOOL_CRUFT=$LIBTOOL_CRUFT" -lSystem -lSystemStubs -arch_only ${MACOSX_DEFAULT_ARCH}"
+-    LIBTOOL_CRUFT=$LIBTOOL_CRUFT' -install_name $(PYTHONFRAMEWORKINSTALLDIR)/Versions/$(VERSION)/$(PYTHONFRAMEWORK)'
+-    LIBTOOL_CRUFT=$LIBTOOL_CRUFT' -compatibility_version $(VERSION) -current_version $(VERSION)';;
+-esac
+ AC_MSG_CHECKING(for --enable-framework)
+ if test "$enable_framework"
+ then