Skip to content

Commit bca3bba

Browse files
committed
windows: install test extensions
This is needed to prevent a bunch of test harness failures. And we even had a TODO tracking this. The extensions don't have their metadata annotated, just like on UNIX. Also, the official Python installers seem to install the extensions as well. So we are slowly converging on parity with them. Unfortunately, we can only do this on shared distributions, as building in static mode yields a ton of missing symbol errors. This is probably fixable. But will require more work. We can do that as a follow-up.
1 parent e49b6be commit bca3bba

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

cpython-windows/build.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,8 +1088,8 @@ def run_msbuild(
10881088
"/property:IncludeSSL=true",
10891089
# TODO support tkinter in static builds.
10901090
"/property:IncludeTkinter=%s" % ("false" if static else "true"),
1091-
# TODO compile test extensions so we can get PGO benefits of tested code.
1092-
"/property:IncludeTests=false",
1091+
# TODO support test extensions in static builds.
1092+
"/property:IncludeTests=%s" % ("false" if static else "true"),
10931093
"/property:OverrideVersion=%s" % python_version,
10941094
]
10951095

@@ -1256,7 +1256,16 @@ def collect_python_build_artifacts(
12561256
# Projects that aren't relevant to us.
12571257
ignore_projects = {
12581258
# We don't care about build artifacts for the python executable.
1259-
"python"
1259+
"python",
1260+
# Test extensions.
1261+
"_ctypes_test",
1262+
"_testbuffer",
1263+
"_testcapi",
1264+
"_testconsole",
1265+
"_testembed",
1266+
"_testimportmultiple",
1267+
"_testmultiphase",
1268+
"xxlimited",
12601269
}
12611270

12621271
other_projects = {"pythoncore"}

0 commit comments

Comments
 (0)