Skip to content

Commit cc9da9c

Browse files
committed
windows: remove shlwapi from links annotation on Python 3.9
This DLL dependency was dropped in 3.9.9. The patch will also be in 3.10.1, which isn't yet released.
1 parent 4ff995a commit cc9da9c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

cpython-windows/build.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1866,7 +1866,6 @@ def find_additional_dependencies(project: pathlib.Path):
18661866
# distribution.
18671867
# TODO pull from unaltered file
18681868
res["core"]["links"] = [
1869-
{"name": "shlwapi", "system": True},
18701869
{"name": "version", "system": True},
18711870
{"name": "ws2_32", "system": True},
18721871
# In addition to the ones explicitly in the project, there are some
@@ -1880,6 +1879,10 @@ def find_additional_dependencies(project: pathlib.Path):
18801879
if python_majmin != "3.8":
18811880
res["core"]["links"].append({"name": "pathcch", "system": True})
18821881

1882+
# shlwapi was dropped from 3.9.9+.
1883+
if python_majmin != "3.9":
1884+
res["core"]["links"].append({"name": "shlwapi", "system": True})
1885+
18831886
# Copy files for extensions into their own directories.
18841887
for ext in sorted(extension_projects):
18851888
dest_dir = out_dir / "build" / "extensions" / ext

pythonbuild/downloads.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
"license_file": "LICENSE.cpython.txt",
7171
"python_tag": "cp39",
7272
},
73+
# TODO remember to update windows shlwapi link annotation when we upgrade to 3.10.1.
7374
"cpython-3.10": {
7475
"url": "https://www.python.org/ftp/python/3.10.0/Python-3.10.0.tar.xz",
7576
"size": 18726176,

0 commit comments

Comments
 (0)