Skip to content

Commit d05620a

Browse files
committed
Remove the +shared build option; enable implicitly
1 parent 75ff237 commit d05620a

File tree

2 files changed

+3
-19
lines changed

2 files changed

+3
-19
lines changed

cpython-unix/build-main.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,7 @@ def main():
5959
options = set()
6060
options.update({"debug", "noopt", "pgo", "lto", "pgo+lto"})
6161
options.update({f"freethreaded+{option}" for option in options})
62-
link_modes = {"static", "shared"}
63-
options.update(
64-
{f"{option}+{link_mode}" for link_mode in link_modes for option in options}
65-
)
62+
options.update({f"{option}+static" for option in options})
6663
parser.add_argument(
6764
"--options",
6865
choices=options,
@@ -146,10 +143,6 @@ def main():
146143

147144
env = dict(os.environ)
148145

149-
# Default to dynamic linking if no link mode is specified
150-
if not any(link_mode in args.options for link_mode in link_modes):
151-
args.options += "+shared"
152-
153146
env["PYBUILD_HOST_PLATFORM"] = host_platform
154147
env["PYBUILD_TARGET_TRIPLE"] = target_triple
155148
env["PYBUILD_BUILD_OPTIONS"] = args.options

cpython-unix/build.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -847,10 +847,7 @@ def build_cpython(
847847
crt_features.append("musl-dynamic")
848848

849849
musl_version = DOWNLOADS["musl"]["version"]
850-
crt_features.append(
851-
"musl-version:%s"
852-
% musl_version
853-
)
850+
crt_features.append("musl-version:%s" % musl_version)
854851

855852
else:
856853
crt_features.append("glibc-dynamic")
@@ -980,13 +977,7 @@ def main():
980977
options = set()
981978
options.update({"debug", "noopt", "pgo", "lto", "pgo+lto"})
982979
options.update({f"freethreaded+{option}" for option in options})
983-
options.update(
984-
{
985-
f"{option}+{link_mode}"
986-
for link_mode in {"static", "shared"}
987-
for option in options
988-
}
989-
)
980+
options.update({f"{option}+static" for option in options})
990981
parser.add_argument(
991982
"--options",
992983
choices=options,

0 commit comments

Comments
 (0)