Skip to content

Commit df9aec8

Browse files
committed
unix: use explicit variable instead of wildcard make rule
Wildcards can be dangerous.
1 parent d0a6889 commit df9aec8

File tree

1 file changed

+18
-18
lines changed

1 file changed

+18
-18
lines changed

cpython-unix/Makefile

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -97,23 +97,23 @@ $(OUTDIR)/clang-$(CLANG_VERSION)-$(BASE_PLATFORM).tar: $(CLANG_DEPENDS)
9797
$(OUTDIR)/musl-$(MUSL_VERSION)-$(BASE_PLATFORM).tar: $(BASE_TOOLCHAIN_DEPENDS) $(HERE)/build-musl.sh
9898
$(BUILD) musl --platform $(BASE_PLATFORM)
9999

100-
$(OUTDIR)/bdb-$(BDB_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-bdb.sh
101-
$(BUILD) --platform $* bdb
100+
$(OUTDIR)/bdb-$(BDB_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-bdb.sh
101+
$(BUILD) --platform $(PLATFORM) bdb
102102

103-
$(OUTDIR)/bzip2-$(BZIP2_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-bzip2.sh
104-
$(BUILD) --platform $* bzip2
103+
$(OUTDIR)/bzip2-$(BZIP2_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-bzip2.sh
104+
$(BUILD) --platform $(PLATFORM) bzip2
105105

106-
$(OUTDIR)/gdbm-$(GDBM_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-gdbm.sh
107-
$(BUILD) --platform $* gdbm
106+
$(OUTDIR)/gdbm-$(GDBM_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-gdbm.sh
107+
$(BUILD) --platform $(PLATFORM) gdbm
108108

109109
$(OUTDIR)/inputproto-$(INPUTPROTO_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-inputproto.sh
110110
$(BUILD) --platform $(PLATFORM) inputproto
111111

112112
$(OUTDIR)/kbproto-$(KBPROTO_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-kbproto.sh
113113
$(BUILD) --platform $(PLATFORM) kbproto
114114

115-
$(OUTDIR)/libffi-$(LIBFFI_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-libffi.sh
116-
$(BUILD) --platform $* libffi
115+
$(OUTDIR)/libffi-$(LIBFFI_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-libffi.sh
116+
$(BUILD) --platform $(PLATFORM) libffi
117117

118118
$(OUTDIR)/libpthread-stubs-$(LIBPTHREAD_STUBS_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-libpthread-stubs.sh $(OUTDIR)/image-build.tar
119119
$(BUILD) --platform $(PLATFORM) libpthread-stubs
@@ -149,20 +149,20 @@ LIBXCB_DEPENDS = \
149149
$(OUTDIR)/libxcb-$(LIBXCB_VERSION)-$(PLATFORM).tar: $(LIBXCB_DEPENDS)
150150
$(BUILD) --platform $(PLATFORM) libxcb
151151

152-
$(OUTDIR)/ncurses-$(NCURSES_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-ncurses.sh
153-
$(BUILD) --platform $* ncurses
152+
$(OUTDIR)/ncurses-$(NCURSES_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-ncurses.sh
153+
$(BUILD) --platform $(PLATFORM) ncurses
154154

155-
$(OUTDIR)/openssl-$(OPENSSL_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-openssl.sh
156-
$(BUILD) --platform $* openssl
155+
$(OUTDIR)/openssl-$(OPENSSL_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-openssl.sh
156+
$(BUILD) --platform $(PLATFORM) openssl
157157

158-
$(OUTDIR)/libedit-$(LIBEDIT_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(OUTDIR)/ncurses-$(NCURSES_VERSION)-%.tar $(HERE)/build-libedit.sh
159-
$(BUILD) --platform $* libedit
158+
$(OUTDIR)/libedit-$(LIBEDIT_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(OUTDIR)/ncurses-$(NCURSES_VERSION)-$(PLATFORM).tar $(HERE)/build-libedit.sh
159+
$(BUILD) --platform $(PLATFORM) libedit
160160

161-
$(OUTDIR)/libressl-$(LIBRESSL_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-libressl.sh
162-
$(BUILD) --platform $* libressl
161+
$(OUTDIR)/libressl-$(LIBRESSL_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-libressl.sh
162+
$(BUILD) --platform $(PLATFORM) libressl
163163

164-
$(OUTDIR)/readline-$(READLINE_VERSION)-%.tar: $(PYTHON_DEP_DEPENDS) $(OUTDIR)/ncurses-$(NCURSES_VERSION)-$(PLATFORM).tar $(HERE)/build-readline.sh
165-
$(BUILD) --platform $* readline
164+
$(OUTDIR)/readline-$(READLINE_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(OUTDIR)/ncurses-$(NCURSES_VERSION)-$(PLATFORM).tar $(HERE)/build-readline.sh
165+
$(BUILD) --platform $(PLATFORM) readline
166166

167167
$(OUTDIR)/sqlite-$(SQLITE_VERSION)-$(PLATFORM).tar: $(PYTHON_DEP_DEPENDS) $(HERE)/build-sqlite.sh
168168
$(BUILD) --platform $(PLATFORM) sqlite

0 commit comments

Comments
 (0)