Skip to content

Commit f0640c3

Browse files
committed
unix: add Makefile dependency on Python support files
Previously, changes to triple specific Makefiles didn't result in the Python build target being invalidated. Now it does.
1 parent 8ecf73d commit f0640c3

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

cpython-unix/Makefile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ $(OUTDIR)/zlib-$(ZLIB_VERSION)-$(PACKAGE_SUFFIX).tar: $(PYTHON_DEP_DEPENDS) $(HE
249249
$(RUN_BUILD) --docker-image $(DOCKER_IMAGE_BUILD) zlib
250250

251251
PYTHON_DEPENDS := \
252+
$(PYTHON_SUPPORT_FILES) \
252253
$(if $(NEED_BDB),$(OUTDIR)/bdb-$(BDB_VERSION)-$(PACKAGE_SUFFIX).tar) \
253254
$(if $(NEED_BZIP2),$(OUTDIR)/bzip2-$(BZIP2_VERSION)-$(PACKAGE_SUFFIX).tar) \
254255
$(if $(NEED_GDBM),$(OUTDIR)/gdbm-$(GDBM_VERSION)-$(PACKAGE_SUFFIX).tar) \
@@ -264,9 +265,6 @@ PYTHON_DEPENDS := \
264265
$(if $(NEED_UUID),$(OUTDIR)/uuid-$(UUID_VERSION)-$(PACKAGE_SUFFIX).tar) \
265266
$(if $(NEED_XZ),$(OUTDIR)/xz-$(XZ_VERSION)-$(PACKAGE_SUFFIX).tar) \
266267
$(if $(NEED_ZLIB),$(OUTDIR)/zlib-$(ZLIB_VERSION)-$(PACKAGE_SUFFIX).tar) \
267-
$(HERE)/disabled-static-modules.$(PYBUILD_PYTHON_MAJOR_VERSION).$(HOST_PLATFORM) \
268-
$(HERE)/required-extensions.$(PYBUILD_PYTHON_MAJOR_VERSION).$(HOST_PLATFORM) \
269-
$(HERE)/static-modules.$(PYBUILD_PYTHON_MAJOR_VERSION).$(HOST_PLATFORM) \
270268
$(NULL)
271269

272270
ALL_PYTHON_DEPENDS = \

cpython-unix/build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -979,7 +979,7 @@ def main():
979979
with log_path.open("wb") as log_fh:
980980
set_logger(action, log_fh)
981981
if action == "makefiles":
982-
write_triples_makefiles(get_targets(TARGETS_CONFIG), BUILD)
982+
write_triples_makefiles(get_targets(TARGETS_CONFIG), BUILD, SUPPORT)
983983
write_package_versions(BUILD / "versions")
984984

985985
elif action.startswith("image-"):

pythonbuild/utils.py

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,9 @@ def write_if_different(p: pathlib.Path, data: bytes):
127127
fh.write(data)
128128

129129

130-
def write_triples_makefiles(targets, dest_dir: pathlib.Path):
130+
def write_triples_makefiles(
131+
targets, dest_dir: pathlib.Path, support_search_dir: pathlib.Path
132+
):
131133
"""Write out makefiles containing make variable settings derived from config."""
132134
dest_dir.mkdir(parents=True, exist_ok=True)
133135

@@ -152,6 +154,18 @@ def write_triples_makefiles(targets, dest_dir: pathlib.Path):
152154
lines.append("DOCKER_IMAGE_BUILD := build%s\n" % image_suffix)
153155
lines.append("DOCKER_IMAGE_XCB := xcb%s\n" % image_suffix)
154156

157+
for support_file in (
158+
"disabled-static-modules",
159+
"required-extensions",
160+
"static-modules",
161+
):
162+
path = get_target_support_file(
163+
support_search_dir, support_file, python, host_platform, triple
164+
)
165+
lines.append(
166+
"PYTHON_SUPPORT_FILES := $(PYTHON_SUPPORT_FILES) %s\n" % path
167+
)
168+
155169
write_if_different(makefile_path, "".join(lines).encode("ascii"))
156170

157171

0 commit comments

Comments
 (0)