Skip to content

Commit f156f44

Browse files
committed
Update musl dist metadata
1 parent 18ff4fc commit f156f44

File tree

1 file changed

+9
-10
lines changed

1 file changed

+9
-10
lines changed

cpython-unix/build.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -506,12 +506,10 @@ def python_build_info(
506506
)
507507
)
508508

509-
# TODO: Update this for non-static musl
510-
if not musl:
511-
bi["core"]["shared_lib"] = "install/lib/libpython%s%s.so.1.0" % (
512-
version,
513-
binary_suffix,
514-
)
509+
bi["core"]["shared_lib"] = "install/lib/libpython%s%s.so.1.0" % (
510+
version,
511+
binary_suffix,
512+
)
515513

516514
if lto:
517515
llvm_version = DOWNLOADS[clang_toolchain(platform, target_triple)][
@@ -835,9 +833,11 @@ def build_cpython(
835833
crt_features = []
836834

837835
if host_platform == "linux64":
838-
# TODO: Update the musl target triple to reflect it is dynamic
839836
if "musl" in target_triple:
840-
crt_features.append("static")
837+
extension_module_loading.append("shared-library")
838+
crt_features.append("musl-dynamic")
839+
840+
# TODO: Add musl version
841841
else:
842842
extension_module_loading.append("shared-library")
843843
crt_features.append("glibc-dynamic")
@@ -876,8 +876,7 @@ def build_cpython(
876876
"python_stdlib_test_packages": sorted(STDLIB_TEST_PACKAGES),
877877
"python_symbol_visibility": python_symbol_visibility,
878878
"python_extension_module_loading": extension_module_loading,
879-
# TODO: Update this for dynamic musl
880-
"libpython_link_mode": "static" if "musl" in target_triple else "shared",
879+
"libpython_link_mode": "shared",
881880
"crt_features": crt_features,
882881
"run_tests": "build/run_tests.py",
883882
"build_info": python_build_info(

0 commit comments

Comments
 (0)