Remove winsafe (#13779)

We've been using a number of different winapi crates. This PR removes
winsafe in favor of the official windows-* crates, so all of uv's own
winapi calls go through the official windows-* crates.

---------

Co-authored-by: Aria Desires <[email protected]>

Author: konstin

Cargo.lock

@@ -184,10 +184,11 @@ url = { version = "2.5.2", features = ["serde"] }
 version-ranges = { git = "https://github.com/astral-sh/pubgrub", rev = "06ec5a5f59ffaeb6cf5079c6cb184467da06c9db" }
 walkdir = { version = "2.5.0" }
 which = { version = "7.0.0", features = ["regex"] }
+windows = { version = "0.59.0", features = ["Win32_Storage_FileSystem"] }
+windows-core = { version = "0.59.0" }
 windows-registry = { version = "0.5.0" }
 windows-result = { version = "0.3.0" }
 windows-sys = { version = "0.59.0", features = ["Win32_Foundation", "Win32_Security", "Win32_Storage_FileSystem", "Win32_System_Ioctl", "Win32_System_IO", "Win32_System_Registry"] }
-winsafe = { version = "0.0.24", features = ["kernel"] }
 wiremock = { version = "0.6.2" }
 xz2 = { version = "0.1.7" }
 zip = { version = "2.2.3", default-features = false, features = ["deflate", "zstd", "bzip2", "lzma", "xz"] }

Cargo.toml

@@ -31,15 +31,14 @@ tempfile = { workspace = true }
 tokio = { workspace = true, optional = true}
 tracing = { workspace = true }
 
-[target.'cfg(target_os = "windows")'.dependencies]
-winsafe = { workspace = true }
-
 [target.'cfg(any(unix, target_os = "wasi", target_os = "redox"))'.dependencies]
 rustix = { workspace = true }
 
 [target.'cfg(windows)'.dependencies]
 backon = { workspace = true }
 junction = { workspace = true }
+windows = { workspace = true }
+windows-core = { workspace = true }
 
 [features]
 default = []

crates/uv-fs/Cargo.toml

@@ -1,5 +1,26 @@
 use std::path::Path;
 
+#[cfg(windows)]
+#[allow(unsafe_code)] // We need to do an FFI call through the windows-* crates.
+fn get_binary_type(path: &Path) -> windows::core::Result<u32> {
+    use std::os::windows::ffi::OsStrExt;
+    use windows::Win32::Storage::FileSystem::GetBinaryTypeW;
+    use windows_core::PCWSTR;
+
+    // References:
+    // https://github.com/denoland/deno/blob/01a6379505712be34ebf2cdc874fa7f54a6e9408/runtime/permissions/which.rs#L131-L154
+    // https://github.com/conradkleinespel/rooster/blob/afa78dc9918535752c4af59d2f812197ad754e5a/src/quale.rs#L51-L77
+    let mut binary_type = 0u32;
+    let name = path
+        .as_os_str()
+        .encode_wide()
+        .chain(Some(0))
+        .collect::<Vec<u16>>();
+    // SAFETY: winapi call
+    unsafe { GetBinaryTypeW(PCWSTR(name.as_ptr()), &mut binary_type)? };
+    Ok(binary_type)
+}
+
 /// Check whether a path in PATH is a valid executable.
 ///
 /// Derived from `which`'s `Checker`.
@@ -20,9 +41,7 @@ pub fn is_executable(path: &Path) -> bool {
         if !file_type.is_file() && !file_type.is_symlink() {
             return false;
         }
-        if path.extension().is_none()
-            && winsafe::GetBinaryType(&path.display().to_string()).is_err()
-        {
+        if path.extension().is_none() && get_binary_type(path).is_err() {
             return false;
         }
     }