Create copies of args to avoid in-place updates

Author: matt-graham

s2fft/transforms/spherical.py

@@ -155,6 +155,9 @@ def inverse_numpy(
     m_start_ind = L - 1 if reality else 0
     L0 = L_lower
 
+    # Copy flm argument to avoid in-place updates being propagated back to caller
+    flm = flm.copy()
+
     # Apply harmonic normalisation
     flm[L0:] = np.einsum(
         "lm,l->lm", flm[L0:], np.sqrt((2 * np.arange(L0, L) + 1) / (4 * np.pi))

s2fft/transforms/wigner.py

@@ -156,6 +156,9 @@ def inverse_numpy(
         )
     fban = np.zeros(samples.f_shape(L, N, sampling, nside), dtype=np.complex128)
 
+    # Copy flm argument to avoid in-place updates being propagated back to caller
+    flmn = flmn.copy()
+
     flmn[:, L_lower:] = np.einsum(
         "...nlm,...l->...nlm",
         flmn[:, L_lower:],