Skip to content

Commit a7c2723

Browse files
committed
add warning for users when spin (N) is high
1 parent c608309 commit a7c2723

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

s2fft/transforms/spherical.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ def inverse(
7171
between devices is noticable, however as L increases one will asymptotically
7272
recover acceleration by the number of devices.
7373
"""
74+
if spin >= 8:
75+
raise Warning("Recursive transform may provide lower precision beyond spin ~ 8")
7476
if method == "numpy":
7577
return inverse_numpy(flm, L, spin, nside, sampling, reality, precomps, L_lower)
7678
elif method == "jax":
@@ -363,6 +365,8 @@ def forward(
363365
between devices is noticable, however as L increases one will asymptotically
364366
recover acceleration by the number of devices.
365367
"""
368+
if spin >= 8:
369+
raise Warning("Recursive transform may provide lower precision beyond spin ~ 8")
366370
if method == "numpy":
367371
return forward_numpy(f, L, spin, nside, sampling, reality, precomps, L_lower)
368372
elif method == "jax":

s2fft/transforms/wigner.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ def inverse(
7676
between devices is noticable, however as L increases one will asymptotically
7777
recover acceleration by the number of devices.
7878
"""
79+
if N >= 8:
80+
raise Warning("Recursive transform may provide lower precision beyond N ~ 8")
7981
if method == "numpy":
8082
return inverse_numpy(flmn, L, N, nside, sampling, reality, precomps, L_lower)
8183
elif method == "jax":
@@ -395,6 +397,8 @@ def forward(
395397
between devices is noticable, however as L increases one will asymptotically
396398
recover acceleration by the number of devices.
397399
"""
400+
if N >= 8:
401+
raise Warning("Recursive transform may provide lower precision beyond N ~ 8")
398402
if method == "numpy":
399403
return forward_numpy(f, L, N, nside, sampling, reality, precomps, L_lower)
400404
elif method == "jax":

0 commit comments

Comments
 (0)