address minor typos for merge

Author: CosmoMatt

s2fft/precompute_transforms/construct.py

@@ -11,7 +11,7 @@
 
 # Maximum spin number at which Price-McEwen recursion is sufficiently accurate.
 # For spins > PM_MAX_STABLE_SPIN one should default to the Risbo recursion.
-PM_MAX_STABLE_SPIN = 5
+PM_MAX_STABLE_SPIN = 6
 
 
 def spin_spherical_kernel(
@@ -66,15 +66,15 @@ def spin_spherical_kernel(
             + "Defering to complex transform.",
             stacklevel=2,
         )
-    if recursion.lower() == "price-mcewen" and abs(spin) >= PM_MAX_STABLE_SPIN:
+    if recursion.lower() == "price-mcewen" and abs(spin) > PM_MAX_STABLE_SPIN:
         raise ValueError(
-            f"The Price-McEwen can become unstable for spins >= {PM_MAX_STABLE_SPIN}."
+            f"The Price-McEwen recursion can become unstable for spins >= {PM_MAX_STABLE_SPIN}."
         )
 
     if recursion.lower() == "auto":
         # This mode automatically determines which recursion is best suited for the
         # current parameter configuration.
-        recursion = "risbo" if abs(spin) >= PM_MAX_STABLE_SPIN else "price-mcewen"
+        recursion = "risbo" if abs(spin) > PM_MAX_STABLE_SPIN else "price-mcewen"
 
     dl = []
     m_start_ind = L - 1 if reality else 0
@@ -214,15 +214,15 @@ def spin_spherical_kernel_jax(
             + "Defaulting to complex transform.",
             stacklevel=2,
         )
-    if recursion.lower() == "price-mcewen" and abs(spin) >= PM_MAX_STABLE_SPIN:
+    if recursion.lower() == "price-mcewen" and abs(spin) > PM_MAX_STABLE_SPIN:
         raise ValueError(
-            f"The Price-McEwen can become unstable for spins >= {PM_MAX_STABLE_SPIN}."
+            f"The Price-McEwen recursion can become unstable for spins >= {PM_MAX_STABLE_SPIN}."
         )
 
     if recursion.lower() == "auto":
         # This mode automatically determines which recursion is best suited for the
         # current parameter configuration.
-        recursion = "risbo" if abs(spin) >= PM_MAX_STABLE_SPIN else "price-mcewen"
+        recursion = "risbo" if abs(spin) > PM_MAX_STABLE_SPIN else "price-mcewen"
 
     dl = []
     m_start_ind = L - 1 if reality else 0

tests/test_spherical_precompute.py

@@ -8,6 +8,10 @@
 from s2fft.precompute_transforms.spherical import forward, inverse
 from s2fft.sampling import s2_samples as samples
 
+# Maximum spin number at which Price-McEwen recursion is sufficiently accurate.
+# For spins > PM_MAX_STABLE_SPIN one should default to the Risbo recursion.
+PM_MAX_STABLE_SPIN = 6
+
 L_to_test = [12]
 spin_to_test = [-2, 0, 6]
 nside_to_test = [4, 5]
@@ -17,8 +21,6 @@
 methods_to_test = ["numpy", "jax", "torch"]
 recursions_to_test = ["price-mcewen", "risbo", "auto"]
 
-PM_MAX_STABLE_SPIN = 5
-
 
 @pytest.mark.parametrize("L", L_to_test)
 @pytest.mark.parametrize("spin", spin_to_test)