Skip to content

Commit e184f53

Browse files
committed
Add comment about precomputes trading off memory for speed
1 parent 939ae74 commit e184f53

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

notebooks/spherical_harmonic_transform.ipynb

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@
7474
"cell_type": "markdown",
7575
"metadata": {},
7676
"source": [
77-
"If you are planning on applying this transform many times (e.g. during training of a model) we recommend precomputing and storing some small arrays that are used every time. To do this simply compute these and pass as a static argument."
77+
"If you are planning on applying this transform many times (e.g. during training of a model) we recommend precomputing and storing some small arrays that are used every time. This trades off additional memory usage for enhanced speed and should be fine at small and moderate bandlimits `L`.\n",
78+
"\n",
79+
"To do this simply compute these and pass as a static argument."
7880
]
7981
},
8082
{
@@ -113,7 +115,9 @@
113115
"cell_type": "markdown",
114116
"metadata": {},
115117
"source": [
116-
"Again, if you are planning on applying this transform many times we recommend precomputing and storing some small arrays that are used every time. To do this simply compute these and pass as a static argument."
118+
"Again, if you are planning on applying this transform many times we recommend precomputing and storing some small arrays that are used every time. Recall, this trades off additional memory usage for enhanced speed and should be fine at small and moderate bandlimits `L`.\n",
119+
"\n",
120+
"To do this simply compute these and pass as a static argument."
117121
]
118122
},
119123
{
@@ -140,14 +144,14 @@
140144
},
141145
{
142146
"cell_type": "code",
143-
"execution_count": 8,
147+
"execution_count": 7,
144148
"metadata": {},
145149
"outputs": [
146150
{
147151
"name": "stdout",
148152
"output_type": "stream",
149153
"text": [
150-
"Mean absolute error = 8.440183049951758e-11\n"
154+
"Mean absolute error = 8.478196507592078e-11\n"
151155
]
152156
}
153157
],
@@ -157,14 +161,14 @@
157161
},
158162
{
159163
"cell_type": "code",
160-
"execution_count": 9,
164+
"execution_count": 8,
161165
"metadata": {},
162166
"outputs": [
163167
{
164168
"name": "stdout",
165169
"output_type": "stream",
166170
"text": [
167-
"Mean absolute error using precomputes = 8.440183049951758e-11\n"
171+
"Mean absolute error using precomputes = 8.478196507592078e-11\n"
168172
]
169173
}
170174
],
@@ -189,7 +193,7 @@
189193
"name": "python",
190194
"nbconvert_exporter": "python",
191195
"pygments_lexer": "ipython3",
192-
"version": "3.10.0"
196+
"version": "3.11.8"
193197
},
194198
"orig_nbformat": 4,
195199
"vscode": {

0 commit comments

Comments
 (0)