-
Notifications
You must be signed in to change notification settings - Fork 14
Closed
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationgood first issueGood for newcomersGood for newcomers
Description
The documentation of the sampling.so3_samples.f_shape function claims that the storage scheme is
s2fft/s2fft/sampling/so3_samples.py
Lines 16 to 17 in 7cf80bb
| Importantly, the convention adopted for storage of f is :math:`[\beta, \alpha, | |
| \gamma]`, for Euler angles :math:`(\alpha, \beta, \gamma)` following the |
but it returns
(gamma, beta, alpha) as far as I see,s2fft/s2fft/sampling/so3_samples.py
Line 43 in 7cf80bb
| return _ngamma(N), _nbeta(L, sampling), _nalpha(L, sampling) |
which also seems to be consistent with the rest of the library. Is this a mistake in the documentation or did I misunderstand something?
Thanks in advance for the clarification!
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationgood first issueGood for newcomersGood for newcomers