Skip to content

Conversation

@CosmoMatt
Copy link
Collaborator

@CosmoMatt CosmoMatt commented Oct 25, 2024

@jasonmcewen this PR builds on the Fourier-Wigner precompute transform work and implements custom transforms which collectively transform:

  • Subsets of Wigner coefficients (collection of spin spherical harmonic coefficients) to collection of spin signals on sphere
  • Collection of spin signals on sphere to their spin spherical harmonic coefficients (stable wrt spin and can accept duplicated spins as per multimodal data)
  • Signal on SO(3) on a subset of its Wigner coefficients (subset of spin spherical harmonic coefficients).

These are all the core transforms we will need going forward.

@CosmoMatt CosmoMatt requested a review from jasonmcewen October 25, 2024 10:07
@CosmoMatt CosmoMatt self-assigned this Oct 25, 2024
@CosmoMatt CosmoMatt added enhancement New feature or request blocker Blocking other or upcoming tasks labels Oct 25, 2024
Copy link
Contributor

@jasonmcewen jasonmcewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @CosmoMatt, just a few minor comments. Have approved so you can merge once these addressed.

@CosmoMatt CosmoMatt merged commit f6e10a0 into main Nov 11, 2024
2 checks passed
@CosmoMatt CosmoMatt deleted the map/hybrid-risbo-transforms branch November 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker Blocking other or upcoming tasks enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants