Fix pass through of arguments to generate_precomputes in NumPy forward spherical transform
#256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
==========================================
+ Coverage 96.07% 96.12% +0.05%
==========================================
Files 31 31
Lines 3565 3565
==========================================
+ Hits 3425 3427 +2
+ Misses 140 138 -2 ☔ View full report in Codecov by Sentry. |
CosmoMatt
approved these changes
Dec 18, 2024
Collaborator
CosmoMatt
left a comment
CosmoMatt
left a comment
There was a problem hiding this comment.
Good catch! A lot of the development for the numpy functions was a little more lax as we only really used this functionality for regression testing of the JAX functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #255